-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to set listener name for client cli #7621
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Jul 21, 2020
/pulsarbot run-failure-checks |
sijie
added
release/2.6.1
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
labels
Jul 21, 2020
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Jul 22, 2020
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
@murong00 Please merge master code |
wolfstudy
pushed a commit
that referenced
this pull request
Jul 29, 2020
### Motivation Currently, CLI tools `pulsar-client` and `pulsar-perf` cann't specify required listener name when using `advertisedListeners`. ### Modifications Add option `--listener-name` for `pulsar-client` and `pulsar-perf`. (cherry picked from commit 4f5b39a)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation Currently, CLI tools `pulsar-client` and `pulsar-perf` cann't specify required listener name when using `advertisedListeners`. ### Modifications Add option `--listener-name` for `pulsar-client` and `pulsar-perf`.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Currently, CLI tools `pulsar-client` and `pulsar-perf` cann't specify required listener name when using `advertisedListeners`. ### Modifications Add option `--listener-name` for `pulsar-client` and `pulsar-perf`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release/2.6.1
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, CLI tools
pulsar-client
andpulsar-perf
cann't specify required listener name when usingadvertisedListeners
.Modifications
Add option
--listener-name
forpulsar-client
andpulsar-perf
.