Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPP client]Fix the issuer_url parsing failure in oauth2 #7791

Merged
merged 1 commit into from
Aug 10, 2020
Merged

[CPP client]Fix the issuer_url parsing failure in oauth2 #7791

merged 1 commit into from
Aug 10, 2020

Conversation

wolfstudy
Copy link
Member

@wolfstudy wolfstudy commented Aug 10, 2020 •
edited
Loading

Signed-off-by: xiaolong.ran rxl@apache.org

Motivation

The issuer_url in the current cpp example needs to be suffixed with /oauth/token, otherwise it cannot be recognized correctly and the following error will be returned:

OAuth2 auth data: 2020-08-10 15:21:06.117 ERROR [0x10ff855c0] AuthOauth2:243 | Response failed for issuerurl https://cloud.streamnative.dev/oauth2/token. response Code 404 passedin: {
    "grant_type": "client_credentials",
    "client_id": "xxxxxxxxxxxxxxxxxxxxxxxxxxx",
    "client_secret": "xxxxxxxxxxxxxxxxxxxxxxxxxxx",
    "audience": "urn:sn:pulsar:pi-ns:pi-name"
}

libc++abi.dylib: terminating with uncaught exception of type char const*

Modifications

Add a fixed suffix of /oauth/token to issuer_url

Verifying this change

Fix test cases as follows:

  • testOauth2CredentialFile
  • testOauth2WrongSecret
  • testOauth2

@wolfstudy
[CPP client]Fix the issue_url parsing failure in oauth2
349be8b 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy wolfstudy self-assigned this Aug 10, 2020
@wolfstudy wolfstudy added this to the 2.7.0 milestone Aug 10, 2020
@wolfstudy wolfstudy mentioned this pull request Aug 10, 2020
Closed
@wolfstudy wolfstudy merged commit c88ba50 into apache:master Aug 10, 2020
wolfstudy added a commit that referenced this pull request Aug 12, 2020
@wolfstudy
[CPP client]Fix the issue_url parsing failure in oauth2 (#7791)
f7e8288 
Signed-off-by: xiaolong.ran <rxl@apache.org>


### Motivation

The `issuer_url` in the current cpp example needs to be suffixed with `/oauth/token`, otherwise it cannot be recognized correctly and the following error will be returned:

```
OAuth2 auth data: 2020-08-10 15:21:06.117 ERROR [0x10ff855c0] AuthOauth2:243 | Response failed for issuerurl https://cloud.streamnative.dev/oauth2/token. response Code 404 passedin: {
    "grant_type": "client_credentials",
    "client_id": "xxxxxxxxxxxxxxxxxxxxxxxxxxx",
    "client_secret": "xxxxxxxxxxxxxxxxxxxxxxxxxxx",
    "audience": "urn:sn:pulsar:pi-ns:pi-name"
}

libc++abi.dylib: terminating with uncaught exception of type char const*
```


### Modifications

Add a fixed suffix of `/oauth/token` to issuer_url

### Verifying this change

Fix test cases as follows:

- testOauth2CredentialFile
- testOauth2WrongSecret
- testOauth2

(cherry picked from commit c88ba50)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@wolfstudy @huangdx0726
[CPP client]Fix the issue_url parsing failure in oauth2 (apache#7791)
40602f7 
Signed-off-by: xiaolong.ran <rxl@apache.org>


### Motivation

The `issuer_url` in the current cpp example needs to be suffixed with `/oauth/token`, otherwise it cannot be recognized correctly and the following error will be returned:

```
OAuth2 auth data: 2020-08-10 15:21:06.117 ERROR [0x10ff855c0] AuthOauth2:243 | Response failed for issuerurl https://cloud.streamnative.dev/oauth2/token. response Code 404 passedin: {
    "grant_type": "client_credentials",
    "client_id": "xxxxxxxxxxxxxxxxxxxxxxxxxxx",
    "client_secret": "xxxxxxxxxxxxxxxxxxxxxxxxxxx",
    "audience": "urn:sn:pulsar:pi-ns:pi-name"
}

libc++abi.dylib: terminating with uncaught exception of type char const*
```


### Modifications

Add a fixed suffix of `/oauth/token` to issuer_url

### Verifying this change

Fix test cases as follows:

- testOauth2CredentialFile
- testOauth2WrongSecret
- testOauth2
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@wolfstudy
[CPP client]Fix the issue_url parsing failure in oauth2 (apache#7791)
6d0f1cc 
Signed-off-by: xiaolong.ran <rxl@apache.org>


### Motivation

The `issuer_url` in the current cpp example needs to be suffixed with `/oauth/token`, otherwise it cannot be recognized correctly and the following error will be returned:

```
OAuth2 auth data: 2020-08-10 15:21:06.117 ERROR [0x10ff855c0] AuthOauth2:243 | Response failed for issuerurl https://cloud.streamnative.dev/oauth2/token. response Code 404 passedin: {
    "grant_type": "client_credentials",
    "client_id": "xxxxxxxxxxxxxxxxxxxxxxxxxxx",
    "client_secret": "xxxxxxxxxxxxxxxxxxxxxxxxxxx",
    "audience": "urn:sn:pulsar:pi-ns:pi-name"
}

libc++abi.dylib: terminating with uncaught exception of type char const*
```


### Modifications

Add a fixed suffix of `/oauth/token` to issuer_url

### Verifying this change

Fix test cases as follows:

- testOauth2CredentialFile
- testOauth2WrongSecret
- testOauth2
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@wolfstudy
[CPP client]Fix the issue_url parsing failure in oauth2 (apache#7791)
25294bf 
Signed-off-by: xiaolong.ran <rxl@apache.org>


### Motivation

The `issuer_url` in the current cpp example needs to be suffixed with `/oauth/token`, otherwise it cannot be recognized correctly and the following error will be returned:

```
OAuth2 auth data: 2020-08-10 15:21:06.117 ERROR [0x10ff855c0] AuthOauth2:243 | Response failed for issuerurl https://cloud.streamnative.dev/oauth2/token. response Code 404 passedin: {
    "grant_type": "client_credentials",
    "client_id": "xxxxxxxxxxxxxxxxxxxxxxxxxxx",
    "client_secret": "xxxxxxxxxxxxxxxxxxxxxxxxxxx",
    "audience": "urn:sn:pulsar:pi-ns:pi-name"
}

libc++abi.dylib: terminating with uncaught exception of type char const*
```


### Modifications

Add a fixed suffix of `/oauth/token` to issuer_url

### Verifying this change

Fix test cases as follows:

- testOauth2CredentialFile
- testOauth2WrongSecret
- testOauth2
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@wolfstudy
[CPP client]Fix the issue_url parsing failure in oauth2 (apache#7791)
d7aa3c0 
Signed-off-by: xiaolong.ran <rxl@apache.org>


### Motivation

The `issuer_url` in the current cpp example needs to be suffixed with `/oauth/token`, otherwise it cannot be recognized correctly and the following error will be returned:

```
OAuth2 auth data: 2020-08-10 15:21:06.117 ERROR [0x10ff855c0] AuthOauth2:243 | Response failed for issuerurl https://cloud.streamnative.dev/oauth2/token. response Code 404 passedin: {
    "grant_type": "client_credentials",
    "client_id": "xxxxxxxxxxxxxxxxxxxxxxxxxxx",
    "client_secret": "xxxxxxxxxxxxxxxxxxxxxxxxxxx",
    "audience": "urn:sn:pulsar:pi-ns:pi-name"
}

libc++abi.dylib: terminating with uncaught exception of type char const*
```


### Modifications

Add a fixed suffix of `/oauth/token` to issuer_url

### Verifying this change

Fix test cases as follows:

- testOauth2CredentialFile
- testOauth2WrongSecret
- testOauth2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiazhai jiazhai jiazhai approved these changes

@aahmed-se aahmed-se aahmed-se approved these changes

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@sijie sijie Awaiting requested review from sijie

Assignees

@wolfstudy wolfstudy

Labels
release/2.6.1
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wolfstudy @jiazhai @aahmed-se