-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIP-64: [REST] Rest API Produce message. #8125
Conversation
@codelipenghui @sijie I'm still refining the implementation and will work on unit test, but can you take a initial look to see if I'm on the right track? Thanks. |
@codelipenghui Produce logic is working now, I've tested with postman. Can you help take a look on the PR? |
/pulsarbot run-failure-checks |
talked with @sijie and we think the produce message request/response here share many common attributes with WebSocket produce request/response, so instead of creating new class here we should try update the class there and add necessary attributes. This will also help on adding schema support for WebSocket API. |
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
move to 2.8.0 first. |
@codelipenghui I've update the url to /topics/[persistent/non-persistent]/tenant/namespace/topic |
@@ -34,7 +34,7 @@ | |||
* 2.The whole range of hash value could be covered by all the consumers. | |||
* 3.Once a consumer is removed, the left consumers could still serve the whole range. | |||
* | |||
* Initializing with a fixed hash range, by default 2 << 5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an unrelated change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/StickyKeyConsumerSelector.java#L28
Just fixing an inconsistent doc when I saw it, probably doesn't worth a separate for such one line change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good
pulsar-broker/src/main/java/org/apache/pulsar/broker/rest/Topics.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/rest/TopicsBase.java
Show resolved
Hide resolved
/pulsarbot run-failure-checks |
@eolivelli please help take a look |
Discussed with @MarvinCai, he will provide tech inputs for “produce msgs” (we’ll create “REST API” chapter under “Client libraries” this weekend. |
Doc is added #12918 |
### Motivation PIP 64: https://github.com/apache/pulsar/wiki/PIP-64%3A-Introduce-REST-endpoints-for-producing%2C-consuming-and-reading-messages Tested with Postman ### Modifications Add produce message rest api.
Is there a plan to support consume messages with rest api?@MarvinCai @jiazhai |
Motivation
PIP 64: https://github.com/apache/pulsar/wiki/PIP-64%3A-Introduce-REST-endpoints-for-producing%2C-consuming-and-reading-messages
Tested with Postman
Modifications
Add produce message rest api.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation