[C++] Fix some pending requests may never complete when broker's down #8232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Oct 10, 2020
|
Thanks @BewareMyPower for the help |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
jiazhai
pushed a commit
to jiazhai/pulsar
that referenced
this pull request
Oct 12, 2020
…apache#8232) Fixes apache#8230 ### Motivation When `ClientConnection` calls `close`, some promises of pending request were not completed. It may cause some methods that wait for promise become completed never return, like `Reader::hasMessageAvailable`. ### Modifications - Complete `GetLastMessageId` and `GetNamespaceTopics` requests in `ClientConnection::close`. - Refactor `ClientConnection::close`, use move instead of swap to process some fields outside the lock section. - Add error log before connection was closed by read error. ### Verifying this change Try to reproduce apache#8230 , `Reader::hasMessageAvailable` would return `ResultConnectError` if broker was killed by force. (cherry picked from commit 5e60775)
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
…#8232) Fixes #8230 ### Motivation When `ClientConnection` calls `close`, some promises of pending request were not completed. It may cause some methods that wait for promise become completed never return, like `Reader::hasMessageAvailable`. ### Modifications - Complete `GetLastMessageId` and `GetNamespaceTopics` requests in `ClientConnection::close`. - Refactor `ClientConnection::close`, use move instead of swap to process some fields outside the lock section. - Add error log before connection was closed by read error. ### Verifying this change Try to reproduce #8230 , `Reader::hasMessageAvailable` would return `ResultConnectError` if broker was killed by force. (cherry picked from commit 5e60775)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
…apache#8232) Fixes apache#8230 ### Motivation When `ClientConnection` calls `close`, some promises of pending request were not completed. It may cause some methods that wait for promise become completed never return, like `Reader::hasMessageAvailable`. ### Modifications - Complete `GetLastMessageId` and `GetNamespaceTopics` requests in `ClientConnection::close`. - Refactor `ClientConnection::close`, use move instead of swap to process some fields outside the lock section. - Add error log before connection was closed by read error. ### Verifying this change Try to reproduce apache#8230 , `Reader::hasMessageAvailable` would return `ResultConnectError` if broker was killed by force.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8230
Motivation
When
ClientConnectioncallsclose, some promises of pending request were not completed. It may cause some methods that wait for promise become completed never return, likeReader::hasMessageAvailable.Modifications
GetLastMessageIdandGetNamespaceTopicsrequests inClientConnection::close.ClientConnection::close, use move instead of swap to process some fields outside the lock section.Verifying this change
Try to reproduce #8230 ,
Reader::hasMessageAvailablewould returnResultConnectErrorif broker was killed by force.