Added metrics for topic lookups operations #8272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
merlimat
requested review from
ivankelly,
srkukarni,
rdhabalia,
jerrypeng,
aahmed-se and
codelipenghui
aahmed-se
approved these changes
Oct 15, 2020
srkukarni
approved these changes
Oct 15, 2020
codelipenghui
approved these changes
Oct 16, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
merlimat
added a commit
to merlimat/pulsar
that referenced
this pull request
Dec 19, 2020
codelipenghui
added
doc-required
Anonymitaet
added
the
doc-required
Anonymitaet
added
doc-complete
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We currently don't have any metrics to check the rates or latencies of topic lookup operations.
Adding:
pulsar_broker_load_manager_bundle_assigment: Latency summary of bundles ownership opspulsar_broker_lookup:Latency summary of all lookup opspulsar_broker_lookup_redirects: Counter of lookup redirectionspulsar_broker_lookup_failures: Counter of lookup failurespulsar_broker_lookup_answers: Counter of lookup concrete answers (ie: not redirects)pulsar_broker_lookup_pending_requests: Pending lookups in broker (when it hits the max, requests are rejected)pulsar_broker_topic_load_pending_request: Pending topic loads operations