-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pulsar-io] Support authentication on debezium connector #8668
Conversation
@rdhabalia I moved this milestone from 2.7.0 to 2.8.0 because @codelipenghui is cutting a release for 2.7.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to be the right approach. I think the pulsar cluster settings should be inherited from Pulsar Functions Worker settings and passed to the Pulsar IO connector, and then to the Kafka Connect settings.
The change seems to take a different approach to get the cluster settings from functions config. It seems to an anti-pattern on how we manage the pulsar cluster settings for functions and connectors.
I guess you misunderstood the change. There are two kinds of topics here: |
@rdhabalia I realized that when answering the question in the other issue. @jiazhai and I made a mistake when we added the kafka-connect-adapter for debezium. We should try to inherit the pulsar service URL from the function worker. Otherwise, it causes confusion when people attempt to use debezium connector. I'd suggest we fixing the issue instead of introducing more pulsar settings to debezium connector. |
@sijie I agree with your thought that try to inherit the pulsar service URL and auth configs from the function worker. But I dont think we should expose them to |
@rdhabalia Can you review @freeznet 's comment? |
### Motivation Fixes #8668 ### Modifications Expose `PulsarClient` via `BaseContext`, and allow connectors to use the inherited pulsar client from function worker to produce/consume messages. ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is already covered by existing tests, such as: - PulsarOffsetBackingStoreTest - KafkaConnectSourceTest - KafkaConnectSinkTest ### Does this pull request potentially affect one of the following parts: - The public API: `SourceContext` and `SinkContext` need to implement the `getPulsarClient` method
…he#11056) ### Motivation Fixes apache#8668 ### Modifications Expose `PulsarClient` via `BaseContext`, and allow connectors to use the inherited pulsar client from function worker to produce/consume messages. ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is already covered by existing tests, such as: - PulsarOffsetBackingStoreTest - KafkaConnectSourceTest - KafkaConnectSinkTest ### Does this pull request potentially affect one of the following parts: - The public API: `SourceContext` and `SinkContext` need to implement the `getPulsarClient` method
…he#11056) ### Motivation Fixes apache#8668 ### Modifications Expose `PulsarClient` via `BaseContext`, and allow connectors to use the inherited pulsar client from function worker to produce/consume messages. ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is already covered by existing tests, such as: - PulsarOffsetBackingStoreTest - KafkaConnectSourceTest - KafkaConnectSinkTest ### Does this pull request potentially affect one of the following parts: - The public API: `SourceContext` and `SinkContext` need to implement the `getPulsarClient` method
…he#11056) Fixes apache#8668 Expose `PulsarClient` via `BaseContext`, and allow connectors to use the inherited pulsar client from function worker to produce/consume messages. - [ ] Make sure that the change passes the CI checks. This change is already covered by existing tests, such as: - PulsarOffsetBackingStoreTest - KafkaConnectSourceTest - KafkaConnectSinkTest - The public API: `SourceContext` and `SinkContext` need to implement the `getPulsarClient` method (cherry picked from commit cb2ba71)
…he#11056) ### Motivation Fixes apache#8668 ### Modifications Expose `PulsarClient` via `BaseContext`, and allow connectors to use the inherited pulsar client from function worker to produce/consume messages. ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is already covered by existing tests, such as: - PulsarOffsetBackingStoreTest - KafkaConnectSourceTest - KafkaConnectSinkTest ### Does this pull request potentially affect one of the following parts: - The public API: `SourceContext` and `SinkContext` need to implement the `getPulsarClient` method
Motivation
Right now, Kafka-connector/Debezium connector doesn't support tls with source configuration which is used to create pulsar consumer for offset topic. adding support of authentication with source-configuration
pulsar.auth.plugin
,pulsar.auth.plugin.param
,pulsar.tls.insecure.connection
,pulsar.tls.trust.cert
Sample command: