Package management bookkeeper storage implementation #8744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zymap
force-pushed
the
package-management-bookkeeper-storage
branch
from
70887c2
to
baa84b1
Compare
zymap
changed the title
zymap
force-pushed
the
package-management-bookkeeper-storage
branch
from
baa84b1
to
815ffe6
Compare
zymap
changed the title
8 tasks
|
@sijie @jiazhai @codelipenghui Please take a look when you have time. Thanks. |
|
ping |
|
ping @codelipenghui @jiazhai @sijie |
|
ping |
|
|
||
| @Override | ||
| public CompletableFuture<Void> closeAsync() { | ||
| return CompletableFuture.runAsync(() -> this.namespace.close()); |
There was a problem hiding this comment.
We should also close the DistributedLogManager?
There was a problem hiding this comment.
codelipenghui
approved these changes
Dec 3, 2020
1 task
RobertIndie
pushed a commit
to RobertIndie/pulsar
that referenced
this pull request
Dec 8, 2020
Master Issue: apache#8676 ### Motivation Support bookkeeper storage for packages management service. ### Modifications - Add bookkeeper storage provider - Add bookkeeper storage unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #8676
Motivation
Support bookkeeper storage for packages management service.
Modifications