Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support limit max topics per namespace #8942

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

hangc0276
Copy link
Contributor

Fix #8225

Changes

  1. Add topic partition number limit, which only take persistent topic into account, for each namespace
  2. The max topic number of each namespace can only be configured by broker.conf, i will make it configurable dynamic soon
  3. Add the tests for this feature.

@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

@aahmed-se
Copy link
Contributor

The limit should be per namespace.

@sijie
Copy link
Member

sijie commented Dec 14, 2020

@aahmed-se :

The limit should be per namespace.

We usually add a default setting to broker/cluster-level first. Then add the setting to the namespace policy. We should make it consistent.

@sijie sijie added namespace-policy-required area/broker doc-required Your PR changes impact docs and you will update later. labels Dec 14, 2020
@sijie sijie added this to the 2.8.0 milestone Dec 14, 2020
@sijie sijie merged commit 37f3e65 into apache:master Dec 15, 2020
@sijia-w
Copy link
Contributor

sijia-w commented Mar 10, 2021

@hangc0276 @Anonymitaet Shall we add description to this section https://pulsar.apache.org/docs/en/concepts-messaging/#namespaces? I appreciate your confirmation.

@Anonymitaet
Copy link
Member

@sijia-w I think the doc for this newly added configuration maxTopicsPerNamespace should be added to the configuration section:

Need to add configuration name, descriptions, and the default value (0).

@hangc0276 Please correct me if I'm wrong, thanks.

sijie pushed a commit that referenced this pull request Mar 12, 2021
fmiguelez pushed a commit to fmiguelez/pulsar that referenced this pull request Mar 16, 2021
@Anonymitaet Anonymitaet removed the doc-required Your PR changes impact docs and you will update later. label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support limits the max topics per namespace
5 participants