Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pulsar-client] Handle NPE while receiving ack for closed producer #8979

Merged
merged 1 commit into from
Dec 16, 2020
Merged

[pulsar-client] Handle NPE while receiving ack for closed producer #8979

merged 1 commit into from
Dec 16, 2020

Conversation

rdhabalia
Copy link
Contributor

Motivation

Handle NPE when client receives ack for published message by a already closed producer.

[pulsar-client-io-1-1] WARN ClientCnx - [id: 0xcf858ea5, L:/1.1.1.1:1111 - R:pulsar-broker1.uswest.com/2.2.2.2:6651] Exception caught: null
java.lang.NullPointerException: null
at org.apache.pulsar.client.impl.ClientCnx.handleSendReceipt(ClientCnx.java:379) ~[?]
at org.apache.pulsar.shade.org.apache.pulsar.common.api.PulsarDecoder.channelRead(PulsarDecoder.java:189) ~[?]
at org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:356) ~[?]
at org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:342) ~[?]

@rdhabalia rdhabalia added this to the 2.8.0 milestone Dec 16, 2020
@rdhabalia rdhabalia self-assigned this Dec 16, 2020
eolivelli
eolivelli approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Please pick to 2.6 and 2.7

@rdhabalia rdhabalia merged commit 1d41036 into apache:master Dec 16, 2020
@rdhabalia rdhabalia deleted the prod_npe branch December 16, 2020 22:35
@merlimat merlimat added the type/bug The PR fixed a bug or issue reported a bug label Feb 20, 2021
@mwmitchell
Copy link

Experiencing this problem on version 2.6.1. Would be great to have this fix back ported.

@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Mar 23, 2021
codelipenghui pushed a commit that referenced this pull request Mar 23, 2021
@rdhabalia @codelipenghui
[pulsar-client] Handle NPE while receiving ack for closed producer (#…
0c9fdd1 
…8979)

(cherry picked from commit 1d41036)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@eolivelli eolivelli eolivelli approved these changes

@sijie sijie Awaiting requested review from sijie

@jiazhai jiazhai Awaiting requested review from jiazhai

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@nkurihar nkurihar Awaiting requested review from nkurihar

Assignees

@rdhabalia rdhabalia

Labels
area/client cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.6.4 release/2.7.2 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rdhabalia @mwmitchell @merlimat @eolivelli @codelipenghui