Fix Proxy Config bindAddress does not working for servicePort #9068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Dec 28, 2020
codelipenghui
approved these changes
Dec 28, 2020
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
codelipenghui
pushed a commit
that referenced
this pull request
Jan 6, 2021
The proxy config bindAddress, only works for webPort, does not work for the servicePort. (cherry picked from commit 29921a6)
codelipenghui
pushed a commit
that referenced
this pull request
Jan 7, 2021
The proxy config bindAddress, only works for webPort, does not work for the servicePort. (cherry picked from commit 29921a6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The proxy config bindAddress, only works for webPort, does not work for the servicePort.
Modifications
Modify the Netty bootstrap, make it use bindAddress to listen.
Describe the modifications you've done.