Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cpp-client] Fix compilation issue caused by non-virtual destructor #9106

Merged
merged 1 commit into from
Jan 4, 2021
Merged

[cpp-client] Fix compilation issue caused by non-virtual destructor #9106

merged 1 commit into from
Jan 4, 2021

Conversation

tongsucn
Copy link
Contributor

@tongsucn tongsucn commented Jan 1, 2021

Related issue: #9105

@merlimat merlimat added this to the 2.8.0 milestone Jan 2, 2021
@jiazhai
Copy link
Member

jiazhai commented Jan 3, 2021

/pulsarbot run-failure-checks

1 similar comment
@tongsucn
Copy link
Contributor Author

tongsucn commented Jan 3, 2021

/pulsarbot run-failure-checks

@codelipenghui
Copy link
Contributor

@tongsucn Could you please rebase the master branch since there is a test fix in the master branch? It's better do not use the master branch to push PRs. For more details, you can refer to http://pulsar.apache.org/en/contributing/

@tongsucn
Copy link
Contributor Author

tongsucn commented Jan 4, 2021

@codelipenghui It's done, sorry for my fault. I'll use another branch next time :D

@sijie
Copy link
Member

sijie commented Jan 4, 2021

/pulsarbot run-failure-checks

@sijie sijie merged commit 68be899 into apache:master Jan 4, 2021
@sijie sijie mentioned this pull request Jan 4, 2021
Closed
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Jan 7, 2021
codelipenghui pushed a commit that referenced this pull request Jan 7, 2021
@tongsucn @codelipenghui
[cpp-client] Fix compilation issue caused by non-virtual destructor i…
44a70d9 
…n consumer. (#9105) (#9106)

Related issue: #9105

(cherry picked from commit 68be899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@sijie sijie sijie approved these changes

@jiazhai jiazhai jiazhai approved these changes

Assignees

@tongsucn tongsucn

Labels
cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.7.1
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tongsucn @jiazhai @codelipenghui @sijie @merlimat