Create Source tarball using Default ASF Configuration #9184
Conversation
|
@codelipenghui this is the patch for the release |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
There was a problem hiding this comment.
@eolivelli I'd prefer fixing that problem first because 2.7.1 is a minor release, not a major release. I'd prefer not to change the existing release workflow. This change can go into master.
|
@sijie this change does not impact the binaries so it is pretty safe. I suggest to commit this patch to master branch and to 2.7 branch. btw I am fixing the CI error |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
I don't think we should commit this change to a branch release. I understand you fix the build script but I am not sure how will that impact the whole release process. Hence I'd prefer fixing the current build process to include missing files for minor releases. We can use this PR for 2.8 release and onwards. |
|
@sijie agreed. |
|
@sijie @codelipenghui CI passed can you please merge this patch ? |
|
@eolivelli Sorry for the late response, I have merged the PR. |
With this patch we are now using the common ASF configuration to create the "release tarball" to be VOTEd and release during the official VOTE. Currently in 2.6+ we are Changes: - Use ASF apache-source-release-assembly-descriptor - Configure the final name of the artifact - Update the release script src/stage-release.sh used during the release process https://github.com/apache/pulsar/wiki/Release-process - Remove the old "src" descriptor Results: With this change you will find the apache-pulsar-VERSION-src.tar.gz file inside the main "target" directory. It contains the dump of the source tree, according to the default Apache rules (basically it strips out only the GIT releated files). The source tarball that we are going to release and VOTE will be a copy of the git tag from which it has been created Notes: in ASF projects usually you are using the -Papache-release profile but it looks like we are not using it always here https://github.com/apache/pulsar/wiki/Release-process it would be better to activate this package only with a Maven profile, in order to speed up the build when you are not performing a release.
With this patch we are now using the common ASF configuration to create the "release tarball" to be VOTEd and release during the official VOTE.
Currently in 2.6+ we are
Changes:
Results:
With this change you will find the apache-pulsar-VERSION-src.tar.gz file inside the main "target" directory.
It contains the dump of the source tree, according to the default Apache rules (basically it strips out only the GIT releated files).
The source tarball that we are going to release and VOTE will be a copy of the git tag from which it has been created
Notes:
in ASF projects usually you are using the -Papache-release profile but it looks like we are not using it always here https://github.com/apache/pulsar/wiki/Release-process
it would be better to activate this package only with a Maven profile, in order to speed up the build when you are not performing a release.