Only auth _errors_ should log at error level #9325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An authentication failure should not log at error level, as it depends on the credentials that the client provides, which may well be wrong. An authentication/authorization error, where it cannot be decided if credentials are valid or not, is an error that needs operator attention and therefore should be logged at error level.
merlimat
changed the title
merlimat
approved these changes
Jan 26, 2021
sijie
approved these changes
Jan 26, 2021
wolfstudy
approved these changes
Jan 28, 2021
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
michaeljmarshall
pushed a commit
that referenced
this pull request
Dec 10, 2021
An authentication failure should not log at error level, as it depends on the credentials that the client provides, which may well be wrong. An authentication/authorization error, where it cannot be decided if credentials are valid or not, is an error that needs operator attention and therefore should be logged at error level. Co-authored-by: Ivan Kelly <ikelly@splunk.com> Co-authored-by: Matteo Merli <mmerli@splunk.com> Co-authored-by: Sijie Guo <sijie@apache.org> (cherry picked from commit fd9875c)
michaeljmarshall
added
cherry-picked/branch-2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An authentication failure should not log at error level, as it depends
on the credentials that the client provides, which may well be wrong.
An authentication/authorization error, where it cannot be decided if
credentials are valid or not, is an error that needs operator
attention and therefore should be logged at error level.