Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java 11 to Pulsar Build image and upgrade dependencies #9609

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

eolivelli
Copy link
Contributor

@eolivelli eolivelli commented Feb 17, 2021

  • add Java 11
  • remove Java 8
  • set Default Maven version to 3.6.3
  • add Python3/Pip3
  • upgrade Go to 1.13

I had to upgrade Go to 1.13, otherwise the build of the image would fail with this error
golang/go#34202

I had to set the MAVEN_VERSION ARG in order to allow the build to pass

@eolivelli eolivelli changed the title Add Java 11 to Pulsar Build image Add Java 11 to Pulsar Build image and upgrade dependencies Feb 17, 2021
@eolivelli
Copy link
Contributor Author

@merlimat @aahmed-se @lhotari PTAL

After committing this patch we should deploy the build image.
The default regarding Maven is not changed.

The only notable changes are:

  • now we have python3 (instead of python2)
  • now we have Go 1.13 (instead of 1.10)

@aahmed-se
Copy link
Contributor

I would change things start with neewer base image that only has jdk 11 and python3 as default.

@eolivelli
Copy link
Contributor Author

I believe that the transition won't be easy.
We should deploy the new image and start running tests on jdk11 but I guess it will take time to stabilise them.
In the meantime the default jdk is 8 and current CI jobs should continue to run without changes.

@aahmed-se
Copy link
Contributor

Don't see the point of the modifying the current image. We can start with a new image base run the jobs with allowance for failure in parallel.

@eolivelli
Copy link
Contributor Author

@aahmed-se I have dropped JDK8.

I am not sure about the removal of Python 2.7. I guess it will complicate the transition to JDK11.

My point here is to allow CI to run on JDK11, if we make too many changes than the work will be bigger and bigger

@aahmed-se
Copy link
Contributor

@eolivelli this is fine enough changes for one pr, lets try to get the tests to pass.

@eolivelli
Copy link
Contributor Author

/pulsarbot run-failure-tests

@sijie
Copy link
Member

sijie commented Feb 18, 2021

@merlimat @eolivelli and I discussed this in the community meeting. I think we want to keep JDK8 around for backward compatibility consideration. i.e. build a Java8 compatible release using JDK11 and validate it can run with JDK8.

@eolivelli eolivelli force-pushed the build/jdk11-pulsar-build-image branch from 945d35c to 76ed938 Compare February 18, 2021 20:18
@eolivelli
Copy link
Contributor Author

@sijie @merlimat @aahmed-se I have restored the support for JDK8 PTAL

@merlimat merlimat added this to the 2.8.0 milestone Feb 18, 2021
- add Java 11
- set Default Maven version to 3.6.3
- use Python3/Pip3
- upgrade Go to 1.13
@eolivelli eolivelli force-pushed the build/jdk11-pulsar-build-image branch from 76ed938 to 0c906a7 Compare February 19, 2021 07:16
@eolivelli
Copy link
Contributor Author

@aahmed-se please review again

@eolivelli
Copy link
Contributor Author

/pulsarbot run-failure-tests

@eolivelli
Copy link
Contributor Author

please note that the CI is not using this image (so basically CI tests are useless apart from RAT/license headers tests)

@eolivelli
Copy link
Contributor Author

@aahmed-se @merlimat CI passed, can you please merge this patch and publish the new docker image ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants