-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Java 11 to Pulsar Build image and upgrade dependencies #9609
Add Java 11 to Pulsar Build image and upgrade dependencies #9609
Conversation
@merlimat @aahmed-se @lhotari PTAL After committing this patch we should deploy the build image. The only notable changes are:
|
I would change things start with neewer base image that only has jdk 11 and python3 as default. |
I believe that the transition won't be easy. |
Don't see the point of the modifying the current image. We can start with a new image base run the jobs with allowance for failure in parallel. |
@aahmed-se I have dropped JDK8. I am not sure about the removal of Python 2.7. I guess it will complicate the transition to JDK11. My point here is to allow CI to run on JDK11, if we make too many changes than the work will be bigger and bigger |
@eolivelli this is fine enough changes for one pr, lets try to get the tests to pass. |
/pulsarbot run-failure-tests |
@merlimat @eolivelli and I discussed this in the community meeting. I think we want to keep JDK8 around for backward compatibility consideration. i.e. build a Java8 compatible release using JDK11 and validate it can run with JDK8. |
945d35c
to
76ed938
Compare
@sijie @merlimat @aahmed-se I have restored the support for JDK8 PTAL |
- add Java 11 - set Default Maven version to 3.6.3 - use Python3/Pip3 - upgrade Go to 1.13
76ed938
to
0c906a7
Compare
@aahmed-se please review again |
/pulsarbot run-failure-tests |
please note that the CI is not using this image (so basically CI tests are useless apart from RAT/license headers tests) |
@aahmed-se @merlimat CI passed, can you please merge this patch and publish the new docker image ? |
I had to upgrade Go to 1.13, otherwise the build of the image would fail with this error
golang/go#34202
I had to set the MAVEN_VERSION ARG in order to allow the build to pass