[C++] SinglePartition message router is always picking the same partition #9702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/bug
merlimat
requested review from
ivankelly,
sijie,
srkukarni,
jerrypeng,
jiazhai and
codelipenghui
aahmed-se
approved these changes
Feb 24, 2021
BewareMyPower
requested changes
Feb 25, 2021
| ProducerConfiguration::HashingScheme hashingScheme) | ||
| : MessageRouterBase(hashingScheme) { | ||
| boost::random::mt19937 rng(std::chrono::high_resolution_clock::now().time_since_epoch().count()); | ||
| boost::random::uniform_int_distribution<int> dist; |
There was a problem hiding this comment.
Should we use std::random from C++ standard library instead of boost::random?
There was a problem hiding this comment.
Good point. Fixed.
There are also other places where we use it. They should get converted as well .
There was a problem hiding this comment.
Yeah, in BackOff.cc and RoundRobinMessageRouter.cc.
BewareMyPower
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
SinglePartitionMessageRouteris supposed to pick a random partition for a given producer and to stick with that. The problem is that the Crand()call is always using the seed 0 and that ends up having multiple processes to always deterministically pick the same partition.