-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transaction] Transaction coordinator metrics. #9706
Merged
codelipenghui
merged 9 commits into
apache:master
from
congbobo184:congbobo184_transaction_coodinator_metrics
May 21, 2021
Merged
[Transaction] Transaction coordinator metrics. #9706
codelipenghui
merged 9 commits into
apache:master
from
congbobo184:congbobo184_transaction_coodinator_metrics
May 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
/pulsarbot run-failure-checks |
codelipenghui
added
the
doc-required
Your PR changes impact docs and you will update later.
label
Mar 3, 2021
# Conflicts: # pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java
@congbobo184 thanks for your work. Could you please help add docs accordingly? Thanks |
OK, when transaction completely, I will add the docs. |
# Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java
eolivelli
approved these changes
May 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
very useful
congbobo184
changed the title
[Pulsar transaction] Transaction coordinator metrics.
[Transaction] Transaction coordinator metrics.
May 16, 2021
# Conflicts: # pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/TransactionMetadataStore.java
codelipenghui
approved these changes
May 21, 2021
Anonymitaet
removed
the
doc-required
Your PR changes impact docs and you will update later.
label
May 27, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
## Motivation Transaction coordinator metrics add. ## implement ``` /** The transaction coordinatorId. */ private long coordinatorId; /** The active transactions. */ private int actives; /** The committed transaction count of this transaction coordinator. */ public long committedCount; /** The aborted transaction count of this transaction coordinator. */ public long abortedCount; /** The created transaction count of this transaction coordinator. */ public long createdCount; /** The append transaction op log count of this transaction coordinator. */ public long appendLogCount; /** The timeout out transaction count of this transaction coordinator. */ public long timeoutCount; /** The transaction execution latency. */ public StatsBuckets executionLatencyBuckets ```
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
## Motivation Transaction coordinator metrics add. ## implement ``` /** The transaction coordinatorId. */ private long coordinatorId; /** The active transactions. */ private int actives; /** The committed transaction count of this transaction coordinator. */ public long committedCount; /** The aborted transaction count of this transaction coordinator. */ public long abortedCount; /** The created transaction count of this transaction coordinator. */ public long createdCount; /** The append transaction op log count of this transaction coordinator. */ public long appendLogCount; /** The timeout out transaction count of this transaction coordinator. */ public long timeoutCount; /** The transaction execution latency. */ public StatsBuckets executionLatencyBuckets ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Transaction coordinator metrics add.
implement
This is transaction coordinator metrics, if have another useful metrics, we can add in other PR.
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)