Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transaction] Transaction coordinator metrics. #9706

Conversation

congbobo184
Copy link
Contributor

@congbobo184 congbobo184 commented Feb 25, 2021

Motivation

Transaction coordinator metrics add.

implement

    /** The transaction coordinatorId. */
    private long coordinatorId;

    /** The active transactions. */
    private int actives;

    /** The committed transaction count of this transaction coordinator. */
    public long committedCount;

    /** The aborted transaction count of this transaction coordinator. */
    public long abortedCount;

    /** The created transaction count of this transaction coordinator. */
    public long createdCount;

    /** The append transaction op log count of this transaction coordinator. */
    public long appendLogCount;

    /** The timeout out transaction count of this transaction coordinator. */
    public long timeoutCount;

    /** The transaction execution latency. */
    public StatsBuckets executionLatencyBuckets

This is transaction coordinator metrics, if have another useful metrics, we can add in other PR.

Verifying this change

Add the tests for it

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

@congbobo184
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added the doc-required Your PR changes impact docs and you will update later. label Mar 3, 2021
@codelipenghui codelipenghui added this to the 2.8.0 milestone Mar 3, 2021
# Conflicts:
#	pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java
@Anonymitaet
Copy link
Member

@congbobo184 thanks for your work. Could you please help add docs accordingly? Thanks

@congbobo184
Copy link
Contributor Author

@congbobo184 thanks for your work. Could you please help add docs accordingly? Thanks

OK, when transaction completely, I will add the docs.

congbo added 2 commits March 17, 2021 17:14
# Conflicts:
#	pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

very useful

@congbobo184 congbobo184 changed the title [Pulsar transaction] Transaction coordinator metrics. [Transaction] Transaction coordinator metrics. May 16, 2021
congbo added 5 commits May 16, 2021 20:23
# Conflicts:
#	pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/TransactionMetadataStore.java
@codelipenghui codelipenghui merged commit 7814117 into apache:master May 21, 2021
@Anonymitaet Anonymitaet removed the doc-required Your PR changes impact docs and you will update later. label May 27, 2021
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
## Motivation
Transaction coordinator metrics add.

## implement
```
    /** The transaction coordinatorId. */
    private long coordinatorId;

    /** The active transactions. */
    private int actives;

    /** The committed transaction count of this transaction coordinator. */
    public long committedCount;

    /** The aborted transaction count of this transaction coordinator. */
    public long abortedCount;

    /** The created transaction count of this transaction coordinator. */
    public long createdCount;

    /** The append transaction op log count of this transaction coordinator. */
    public long appendLogCount;

    /** The timeout out transaction count of this transaction coordinator. */
    public long timeoutCount;

    /** The transaction execution latency. */
    public StatsBuckets executionLatencyBuckets
```
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
## Motivation
Transaction coordinator metrics add.

## implement
```
    /** The transaction coordinatorId. */
    private long coordinatorId;

    /** The active transactions. */
    private int actives;

    /** The committed transaction count of this transaction coordinator. */
    public long committedCount;

    /** The aborted transaction count of this transaction coordinator. */
    public long abortedCount;

    /** The created transaction count of this transaction coordinator. */
    public long createdCount;

    /** The append transaction op log count of this transaction coordinator. */
    public long appendLogCount;

    /** The timeout out transaction count of this transaction coordinator. */
    public long timeoutCount;

    /** The transaction execution latency. */
    public StatsBuckets executionLatencyBuckets
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants