RANGER-4390: creating another row batch causes null pointer exception #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating another row batch causes null pointer exception as vectorizedRowBatchMap has old batch references and gets garbage collected.
What changes were proposed in this pull request?
In
log(Writer writer, Collection<AuthzAuditEvent> events)
, creating new row batch causes an exception since the new batch renders references in vectorizedRowBatchMap invalid.The creation of new batch is also not necessary as batch of same size was allocated in initORCAuditSchema(). Also, creating a batch larger than orc buffer size is also not useful since the batch is written to writer as soon as its size reaches orc buffer size.
if (batch.size == orcBufferSize) { writer.addRowBatch(batch); batch.reset(); }
How was this patch tested?
The unit test case TestAuditQueue.testAuditFileQueueSpoolORC failed when xasecure.audit.destination.hdfs.batch.filequeue.filespool.buffer.size and xasecure.audit.destination.hdfs.orc.buffersize were unequal. After the fix, the test case passes and now different values (e.g. 10 and 5 respectively as shown below) can be used for these properties.