RATIS-2036 Avoid trigger snapshot when removing raftGroup #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OneSizeFitsQuorum
force-pushed
the
jira2036
branch
from
e8e5e88
to
6e33b0b
Compare
|
@szetszwo PTAL |
szetszwo
reviewed
Mar 22, 2024
There was a problem hiding this comment.
@OneSizeFitsQuorum , thanks for working on this! Then change looks good. Just two minor comments inlined.
Comment on lines
355
to
356
| return (triggerSnapshotWhenStopEnabled || isRemoving) | ||
| && (triggerSnapshotWhenRemoveEnabled || !isRemoving); |
There was a problem hiding this comment.
Let's call it shouldTakeSnapshotAtStop. We may simply the logic as below:
private boolean shouldTakeSnapshotAtStop() {
if (isRemoving) {
return triggerSnapshotWhenRemoveEnabled;
} else {
return triggerSnapshotWhenStopEnabled;
}
}There was a problem hiding this comment.
The codes looks much clearer!
Comment on lines
367
to
370
| void setRemoving() { | ||
| this.isRemoving = true; | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's move it to right below shouldTakeSnapshotAtStop().
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
szetszwo
approved these changes
Mar 23, 2024
SzyWilliam
pushed a commit
that referenced
this pull request
Mar 27, 2024
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Apr 11, 2024
SzyWilliam
pushed a commit
to SzyWilliam/ratis
that referenced
this pull request
Jun 12, 2024
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see jira