Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RATIS-2153. ratis-version.properties missing from src bundle #1147

Merged
merged 1 commit into from
Sep 10, 2024
Merged

RATIS-2153. ratis-version.properties missing from src bundle #1147

merged 1 commit into from
Sep 10, 2024

Conversation

adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Sep 9, 2024 •
edited
Loading

What changes were proposed in this pull request?

ratis-version.properties added in RATIS-1840 needs to be included in the src assembly.

https://issues.apache.org/jira/browse/RATIS-2153

How was this patch tested?

$ mvn -DskipTests clean verify
...

$ tar tzvf ratis-assembly/target/ratis-assembly-*-src.tar.gz | grep 'src/src'
drwxr-xr-x root/root         0 2023-11-19 15:23 apache-ratis-3.2.0-SNAPSHOT-src/src/
drwxr-xr-x root/root         0 2023-11-19 15:23 apache-ratis-3.2.0-SNAPSHOT-src/src/main/
drwxr-xr-x root/root         0 2023-11-19 15:23 apache-ratis-3.2.0-SNAPSHOT-src/src/main/resources/
-rw-r--r-- root/root       873 2023-11-19 15:23 apache-ratis-3.2.0-SNAPSHOT-src/src/main/resources/ratis-version.properties

CI:
https://github.com/adoroszlai/ratis/actions/runs/10778262480

@adoroszlai adoroszlai self-assigned this Sep 9, 2024
szetszwo
szetszwo approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

OneSizeFitsQuorum
OneSizeFitsQuorum approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adoroszlai adoroszlai merged commit 1918432 into apache:master Sep 10, 2024
11 of 12 checks passed
@adoroszlai adoroszlai deleted the RATIS-2153 branch September 10, 2024 06:13
adoroszlai added a commit that referenced this pull request Sep 10, 2024
@adoroszlai
RATIS-2153. ratis-version.properties missing from src bundle (#1147)
342688d 
(cherry picked from commit 1918432)
@adoroszlai
Copy link
Contributor Author

Thanks @OneSizeFitsQuorum, @szetszwo for the review. I've also cherry-picked this to the release-3.1.1 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szetszwo szetszwo szetszwo approved these changes

@OneSizeFitsQuorum OneSizeFitsQuorum OneSizeFitsQuorum approved these changes

Assignees

@adoroszlai adoroszlai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adoroszlai @szetszwo @OneSizeFitsQuorum