Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RATIS-2154. The old leader may send appendEntries after term changed, #1148

Merged
merged 2 commits into from
Sep 12, 2024
Merged

RATIS-2154. The old leader may send appendEntries after term changed, #1148

merged 2 commits into from
Sep 12, 2024

Conversation

133tosakarin
Copy link
Contributor

@133tosakarin 133tosakarin commented Sep 10, 2024 •
edited
Loading

Previous PR see #1133
issue see https://issues.apache.org/jira/browse/RATIS-2138

This PR is the follow-up to 2138
This PR related issue: https://issues.apache.org/jira/browse/RATIS-2154

@133tosakarin 133tosakarin marked this pull request as draft September 11, 2024 03:28
@133tosakarin 133tosakarin changed the title RATIS-2138. Remove uncessary error log in JVMPauseMonitor When GC is serious Demo RATIS-2138. Remove uncessary error log in JVMPauseMonitor When GC is serious Sep 11, 2024
@133tosakarin 133tosakarin changed the title Demo RATIS-2138. Remove uncessary error log in JVMPauseMonitor When GC is serious RATIS-2154. Discussion on whether it is necessary to remove unnecessary error logs in JVMPauseMonitor when GC is severe Sep 12, 2024
@133tosakarin 133tosakarin marked this pull request as ready for review September 12, 2024 01:50
@133tosakarin 133tosakarin changed the title RATIS-2154. Discussion on whether it is necessary to remove unnecessary error logs in JVMPauseMonitor when GC is severe RATIS-2154. Discussion on follow-up when deleting unnecessary error logs GC severe in JVMPauseMonitor Sep 12, 2024
OneSizeFitsQuorum
OneSizeFitsQuorum approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum
Copy link
Contributor

@szetszwo PTAL

szetszwo
szetszwo approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@szetszwo szetszwo changed the title RATIS-2154. Discussion on follow-up when deleting unnecessary error logs GC severe in JVMPauseMonitor RATIS-2154. The old leader may send appendEntries after term changed, Sep 12, 2024
@szetszwo szetszwo merged commit e6fe8fc into apache:master Sep 12, 2024
12 checks passed
OneSizeFitsQuorum pushed a commit that referenced this pull request Sep 13, 2024
@133tosakarin @OneSizeFitsQuorum
RATIS-2154. The old leader may send appendEntries after term changed. (…
5578be7 
…#1148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szetszwo szetszwo szetszwo approved these changes

@OneSizeFitsQuorum OneSizeFitsQuorum OneSizeFitsQuorum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@133tosakarin @OneSizeFitsQuorum @szetszwo