RATIS-1627. InstallSnapshotRequests add properties : totalSize #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
reviewed
Jul 18, 2022
ratis-server/src/main/java/org/apache/ratis/server/leader/InstallSnapshotRequests.java
Outdated
Show resolved
Hide resolved
szetszwo
approved these changes
Jul 19, 2022
szetszwo
pushed a commit
that referenced
this pull request
Jul 21, 2022
(cherry picked from commit a69f3fb)
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
in method : org.apache.ratis.server.leader.InstallSnapshotRequests#newInstallSnapshotRequest;
it is unnecessary to compute repeatedly the total size of snapshot .
What is the link to the Apache JIRA
RATIS-1627. InstallSnapshotRequests add properties : totalSize
https://issues.apache.org/jira/browse/RATIS-1627
How was this patch tested?