RATIS-1635. Support listener in MiniRaftCluster #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@szetszwo Could you help review this pull request? Thank you in advance! |
szetszwo
reviewed
Jul 22, 2022
There was a problem hiding this comment.
@codings-dan , thanks for working on this! Just two minor comments inlined.
| @@ -39,9 +39,9 @@ public class MiniRaftClusterWithGrpc extends MiniRaftCluster.RpcBase { | |||
| public static final Factory<MiniRaftClusterWithGrpc> FACTORY | |||
| = new Factory<MiniRaftClusterWithGrpc>() { | |||
| @Override | |||
| public MiniRaftClusterWithGrpc newCluster(String[] ids, RaftProperties prop) { | |||
| public MiniRaftClusterWithGrpc newCluster(String[] ids, String[] ids1, RaftProperties prop) { | |||
There was a problem hiding this comment.
Rename all ids1 to listenerIds.
| } | ||
|
|
||
| public PeerChanges addNewPeers(int number, boolean startNewPeer, | ||
| boolean emptyPeer, boolean isListener) throws IOException { |
There was a problem hiding this comment.
Similar to other code, pass RaftPeerRole instead of isListener.
|
@szetszwo PTAL, thank you! |
szetszwo
approved these changes
Jul 23, 2022
|
@szetszwo Thanks for helping review and merge the pull request! |
codings-dan
added a commit
that referenced
this pull request
Jul 26, 2022
(cherry picked from commit 7e69560)
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://issues.apache.org/jira/browse/RATIS-1635