Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-1727. Typo: change GrpcConfigKey 'useCached' to useSeparate #767

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

SzyWilliam
Copy link
Member

@SzyWilliam SzyWilliam commented Oct 20, 2022

What changes were proposed in this pull request?

After upgrading to Ratis 2.4.0, I found the param name for heartbeatChannel is confusing.
It should be useSeparate instead of useCached

Jira issue: https://issues.apache.org/jira/browse/RATIS-1727

Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@szetszwo
Copy link
Contributor

@SzyWilliam, is there a JIRA for this? If not, could you file one?

@SzyWilliam SzyWilliam changed the title Typo: change GrpcConfigKey 'useCached' to useSeparate RATIS-1727. Typo: change GrpcConfigKey 'useCached' to useSeparate Oct 23, 2022
@SzyWilliam
Copy link
Member Author

@szetszwo Just created one, see https://issues.apache.org/jira/browse/RATIS-1727. Thanks!

@szetszwo szetszwo merged commit 7c104be into apache:master Oct 23, 2022
@szetszwo
Copy link
Contributor

@SzyWilliam , thanks!

szetszwo pushed a commit that referenced this pull request Nov 8, 2022
codings-dan pushed a commit that referenced this pull request Nov 9, 2022
symious pushed a commit to symious/ratis that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants