Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RATIS-1811. Improve StreamObserver's log messages #849

Merged
merged 2 commits into from
Mar 9, 2023
Merged

RATIS-1811. Improve StreamObserver's log messages #849

merged 2 commits into from
Mar 9, 2023

Conversation

SzyWilliam
Copy link
Member

szetszwo
szetszwo approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@szetszwo szetszwo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

(We may simply use op as below.)

      GrpcUtil.warn(LOG, () -> getId() + ": " + op + " onError, lastRequest: " + getPreviousRequestString(), t);

@SzyWilliam
Copy link
Member Author

@szetszwo Thanks for the review! Changed to the simple version.

@SzyWilliam SzyWilliam merged commit 1ca77a1 into apache:master Mar 9, 2023
szetszwo pushed a commit that referenced this pull request Mar 22, 2023
@SzyWilliam @szetszwo
RATIS-1811. Improve StreamObserver's log messages (#849)
2524460 
(cherry picked from commit 1ca77a1)
symious pushed a commit to symious/ratis that referenced this pull request Mar 16, 2024
@SzyWilliam @symious
RATIS-1811. Improve StreamObserver's log messages (apache#849)
540dac7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szetszwo szetszwo szetszwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SzyWilliam @szetszwo