Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-1822. Disable first election on changeToFollower #863

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

SzyWilliam
Copy link
Member

What changes were proposed in this pull request?

Currently, first election is disabled on setLeader. However, it does not cover all scenarios. For example, when a candidate receives DISCOVERED_A_NEW_TERM as the response to PreVote, it should also disable first election.

Therefore, I propose to disable first election on changeToFollower

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/RATIS-1822

How was this patch tested?

Existing unit tests.

Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants