Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-1870. Refactor hasMajority code during configuration changes #902

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

SzyWilliam
Copy link
Member

See https://issues.apache.org/jira/browse/RATIS-1870.

The patch includes two changes:

  1. Add considerations on OldConf when deciding whether leader is working as singleton.
  2. Move hasMajority related code to RaftConfigurationImpl.

Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the refactoring is very nice! It simplifies the code.

@szetszwo szetszwo merged commit c8f4c46 into apache:master Aug 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants