Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #651] fix an issue where a map read operation was not protected by the lock #652

Merged

Conversation

czah
Copy link
Contributor

@czah czah commented May 6, 2021

What is the purpose of the change

see #651

Brief changelog

Aquire lock before accessing the indexer.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #652 (64cbc7f) into master (dfa26d1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   24.36%   24.39%   +0.02%     
==========================================
  Files          48       48              
  Lines        5204     5202       -2     
==========================================
+ Hits         1268     1269       +1     
+ Misses       3726     3724       -2     
+ Partials      210      209       -1     
Impacted Files Coverage Δ
producer/selector.go 73.68% <100.00%> (+6.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfa26d1...64cbc7f. Read the comment docs.

@maixiaohai maixiaohai changed the title fix(queue-selector): fix an issue where a map read operation was not … fix(queue-selector): fix an issue where a map read operation was not protected by the lock May 6, 2021
@czah czah changed the title fix(queue-selector): fix an issue where a map read operation was not protected by the lock [ISSUE #651] fix an issue where a map read operation was not protected by the lock May 6, 2021
Copy link
Contributor

@maixiaohai maixiaohai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maixiaohai maixiaohai added the wip label May 19, 2021
@wenfengwang wenfengwang merged commit 7993abb into apache:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants