Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #818] fix msg.Body compressed cause error in transaction message processing #679

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

trxo
Copy link
Contributor

@trxo trxo commented Jun 16, 2021

fix msg.Body compressed and not reset, cause error in transaction message processing(when execute ExecuteLocalTransaction func,the compressed msg.Body is binary. In our scenario, it directly leads to the failure of json serialization

What is the purpose of the change

bugfix

Brief changelog

add Message.CompressedBody store compressed msg body

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Member

@Git-Yang Git-Yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you create an ISSUE?

@trxo
Copy link
Contributor Author

trxo commented Apr 21, 2022

LGTM! Can you create an ISSUE?
ok ,I will process later

@Git-Yang Git-Yang changed the title fix msg.Body compressed cause error in transaction message processing [ISSUE #818] fix msg.Body compressed cause error in transaction message processing Apr 25, 2022
@Git-Yang Git-Yang merged commit 853f304 into apache:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] msg.Body compressed cause error in transaction message processing
3 participants