Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #878] Clean expired message in CLUSTERING model for push_consumer #879

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

cserwen
Copy link
Member

@cserwen cserwen commented Aug 1, 2022

What is the purpose of the change

Fix #878

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #879 (386bf60) into master (0fb106c) will increase coverage by 0.00%.
The diff coverage is 25.92%.

❗ Current head 386bf60 differs from pull request most recent head cddf564. Consider uploading reports for the commit cddf564 to get more accurate results

@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   25.00%   25.00%           
=======================================
  Files          51       51           
  Lines        6632     6666   +34     
=======================================
+ Hits         1658     1667    +9     
- Misses       4750     4773   +23     
- Partials      224      226    +2     
Impacted Files Coverage Δ
consumer/push_consumer.go 11.34% <22.72%> (+0.29%) ⬆️
consumer/option.go 23.71% <40.00%> (+0.05%) ⬆️
primitive/ctx.go 0.00% <0.00%> (ø)
producer/interceptor.go 0.00% <0.00%> (ø)
producer/producer.go 28.35% <0.00%> (+0.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@cserwen cserwen force-pushed the clean_expired_msg branch 3 times, most recently from 7994c7a to fe79ff6 Compare August 1, 2022 11:28
@ShannonDing ShannonDing added the enhancement New feature or request label Aug 2, 2022
@ShannonDing ShannonDing added this to the 2.2.0 milestone Aug 2, 2022
@ShannonDing ShannonDing merged commit 5aa04a2 into apache:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean expired messages not work in clustering mode for push_consumer
3 participants