Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #929] Correct struct comment #930

Merged
merged 1 commit into from
Oct 13, 2022
Merged

[ISSUE #929] Correct struct comment #930

merged 1 commit into from
Oct 13, 2022

Conversation

Oliverwqcwrw
Copy link
Member

What is the purpose of the change

Close #929

Brief changelog

Correct struct comment

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Merging #930 (0cb88f7) into master (92515f7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #930   +/-   ##
=======================================
  Coverage   23.61%   23.61%           
=======================================
  Files          52       52           
  Lines        7170     7170           
=======================================
  Hits         1693     1693           
  Misses       5247     5247           
  Partials      230      230           
Impacted Files Coverage Δ
primitive/result.go 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShannonDing ShannonDing merged commit 8011561 into apache:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

correct struct comment
4 participants