Client configuration add namespace #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
fengmk2
reviewed
May 11, 2024
nodejs/src/client/BaseClient.ts
Outdated
| @@ -76,6 +77,7 @@ export abstract class BaseClient { | |||
| readonly clientType = ClientType.CLIENT_TYPE_UNSPECIFIED; | |||
| readonly sslEnabled: boolean; | |||
| readonly #sessionCredentials?: SessionCredentials; | |||
| readonly namespace?: string = ""; | |||
There was a problem hiding this comment.
readonly namespace?: string; 即可，可选属性不需要设置空值。
fengmk2
reviewed
May 11, 2024
nodejs/src/client/Settings.ts
Outdated
| @@ -20,15 +20,17 @@ import { Endpoints } from '../route/Endpoints'; | |||
| import { RetryPolicy } from '../retry'; | |||
|
|
|||
| export abstract class Settings { | |||
| protected readonly namespace: string | ""; | |||
There was a problem hiding this comment.
protected readonly namespace: string;
guyinyou
reviewed
May 15, 2024
| @@ -60,8 +60,11 @@ export class SimpleConsumer extends Consumer { | |||
| } | |||
| } | |||
| this.#awaitDuration = options.awaitDuration ?? 30000; | |||
| this.#simpleSubscriptionSettings = new SimpleSubscriptionSettings(this.clientId, this.endpoints, | |||
| this.consumerGroup, this.requestTimeout, this.#awaitDuration, this.#subscriptionExpressions); | |||
| if (options.namespace) { | |||
There was a problem hiding this comment.
这里给namespace初始化一个空字符串，就不需要多次判空了，proxy侧会兼容空字符串的情况将其认为是默认值
RongtongJin
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #issue_id
Brief Description
How Did You Test This Change?