Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] bugfix: CopyOnWriteArray#listIterator do not support remove action when iterating #7684

Closed
3 tasks done
EvanMi opened this issue Dec 20, 2023 · 0 comments
Closed
3 tasks done

[Bug] bugfix: CopyOnWriteArray#listIterator do not support remove action when iterating #7684

EvanMi opened this issue Dec 20, 2023 · 0 comments

Comments

@EvanMi
Copy link
Contributor

EvanMi commented Dec 20, 2023

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

all

RocketMQ version

all

JDK Version

all

Describe the Bug

CopyOnWriteArray#listIterator do not support remove action when iterating, but MappedFileQueue#resetOffset used it

Steps to Reproduce

see #7682 testcase

What Did You Expect to See?

reset success

What Did You See Instead?

failed

Additional Context

PR #7682 fixed this promblem
@EvanMi EvanMi mentioned this issue Dec 20, 2023
Merged
RongtongJin pushed a commit that referenced this issue Dec 20, 2023
@EvanMi
[ISSUE #7684] Fix iterator.remove() bug (#7682)
f0a3e93 
* bugfix: CopyOnWriteArray#listIterator do not support remove action when iterating

* add testcase

---------

Co-authored-by: mipengcheng3 <mipengcheng3@jd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RongtongJin @EvanMi