Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #2833] Support trace for TranscationProducer #2834

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

yuz10
Copy link
Member

@yuz10 yuz10 commented Apr 23, 2021

Make sure set the target branch to develop

Support trace for TranscationProducer

In order to send commit/rollback trace data, add "EndTransactionHook", and register the hook if enableMsgTrace is true.

Add a new type of trace data, "EndTransaction" to indicate that a commit/rollback is sent

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [y] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [y] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [y] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [y] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [y] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #2834 (6cee912) into develop (bc4ecb3) will increase coverage by 0.55%.
The diff coverage is 71.09%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2834      +/-   ##
=============================================
+ Coverage      46.52%   47.07%   +0.55%     
- Complexity      3426     3482      +56     
=============================================
  Files            307      309       +2     
  Lines          29059    29186     +127     
  Branches        4172     4175       +3     
=============================================
+ Hits           13520    13740     +220     
+ Misses         13697    13583     -114     
- Partials        1842     1863      +21     
Impacted Files Coverage Δ Complexity Δ
...client/trace/hook/EndTransactionTraceHookImpl.java 13.33% <13.33%> (ø) 2.00 <2.00> (?)
...he/rocketmq/client/producer/DefaultMQProducer.java 52.63% <50.00%> (-0.03%) 41.00 <0.00> (ø)
...mq/client/impl/producer/DefaultMQProducerImpl.java 44.64% <77.77%> (+7.41%) 83.00 <5.00> (+12.00)
...he/rocketmq/client/hook/EndTransactionContext.java 86.36% <86.36%> (ø) 12.00 <12.00> (?)
...apache/rocketmq/client/trace/TraceDataEncoder.java 70.32% <97.14%> (+8.65%) 11.00 <0.00> (+2.00)
...ocketmq/client/producer/TransactionMQProducer.java 42.55% <100.00%> (+42.55%) 10.00 <0.00> (+10.00)
...va/org/apache/rocketmq/client/trace/TraceBean.java 98.03% <100.00%> (+0.42%) 29.00 <6.00> (+6.00)
...va/org/apache/rocketmq/client/trace/TraceType.java 100.00% <100.00%> (ø) 1.00 <0.00> (ø)
...etmq/client/latency/LatencyFaultToleranceImpl.java 50.00% <0.00%> (-1.29%) 8.00% <0.00%> (ø%)
...a/org/apache/rocketmq/store/StoreStatsService.java 30.16% <0.00%> (-0.66%) 27.00% <0.00%> (-1.00%)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc4ecb3...6cee912. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 52.339% when pulling 6cee912 on yuz10:develop into bc4ecb3 on apache:develop.

@vongosling vongosling added this to the 4.9.0 milestone Apr 26, 2021
@vongosling vongosling linked an issue Apr 26, 2021 that may be closed by this pull request
@vongosling
Copy link
Member

Spring RocketMQ will need to integrate this feature, make a note here.

@vongosling vongosling merged commit c3d4641 into apache:develop Apr 26, 2021
vongosling added a commit that referenced this pull request May 19, 2021
* [ISSUE #1233] Fix CVE-2011-1473

* fix Multiple instances in the same application share MQClientInstance

* [ISSUE #2748] Fix deleteSubscriptionGroup not remove consumer offset

* [ISSUE #2745] Changed the support time of the request/reply feature to 4.6.0.

Co-authored-by: von gosling <vongosling@apache.org>

* [ISSUE #2729] Replace with Math.min method call

* [ISSUE #2801]Fix NamesrvAddr connot set in Producer

* [ISSUE 2800] optimize: the spelling of topicSynFlag

Co-authored-by: ph3636 <tianxingguang@kanzhun.com>

* [ISSUE #2803] Fix the endpoint cannot get instanceId without http (#2804)

* fix the endpoint cannot get instanceId without http

* fix the endpoint cannot get instanceId without http

* add unit test

* add unit test

* add unit test

Co-authored-by: panzhi33 <wb-pz502261@alibaba-inc.com>

* fix messageArrivingListener NPE

* [ISSUE #2538]Optimize log output when message trace saving fails

* [ISSUE #2811] Fix the wrong topic was consumed in the DefaultMessageStoreTest test program

* [ISSUE #2821] Overriding the ServiceThread#shutdown in HAClient class

* [ISSUE #2805] remove redundant package imports

* [ISSUE #2833] Support trace for TranscationProducer (#2834)

* [ISSUE #2732] Fix message loss problem when rebalance with LitePullConsumer (#2832)

* [ISSUE #2732] Fix message loss problem when rebalance with LitePullConsumer

* Fix message loss problem when rebalance with LitePullConsumer, update 2

* [ISSUE #2846]fix -E might not port to other systems

* fix some nonconformity after checkstyle

* Support OpenTracing(#2861)

* [ISSUE #2872] remove log files created by integration test when mvn clean

* [ISSUE #2872] move log files created by integration test to target dir

* Change log level to debug: "Half offset {} has been committed/rolled back"

* Fix unit test stability

Bump mockito-core to 3.10.0, remove powermock dependency, suppress useless logging

* [ISSUE #2898] Resolve rocketmq-example project failed during checkstyle execution (#2899)

Co-authored-by: SSpirits <shadowyspirits@outlook.com>
Co-authored-by: panzhi33 <wb-pz502261@alibaba-inc.com>
Co-authored-by: panzhi <panzhi33@qq.com>
Co-authored-by: ArronHuang <41609451+ArronHuang@users.noreply.github.com>
Co-authored-by: von gosling <vongosling@apache.org>
Co-authored-by: drgnchan <40224023+drgnchan@users.noreply.github.com>
Co-authored-by: zhangjidi2016 <zhangjidi@cmss.chinamobile.com>
Co-authored-by: ph3636 <38041490+ph3636@users.noreply.github.com>
Co-authored-by: ph3636 <tianxingguang@kanzhun.com>
Co-authored-by: BurningCN <1015773611@qq.com>
Co-authored-by: francis lee <francislee.cn@outlook.com>
Co-authored-by: 灼华 <43363120+BurningCN@users.noreply.github.com>
Co-authored-by: yuz10 <845238369@qq.com>
Co-authored-by: huangli <areyouok@gmail.com>
Co-authored-by: chenrl <raymond2366@outlook.com>
Co-authored-by: ayanamist <ayanamist@gmail.com>
Co-authored-by: zhangjidi2016 <1017543663@qq.com>
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support trace for TranscationProducer
4 participants