Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3048]add example of OnewayProducer and ScheduledMessage #3053

Merged
merged 5 commits into from
Jan 24, 2022

Conversation

zplovekq
Copy link
Contributor

@zplovekq zplovekq commented Jun 23, 2021

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
    [ISSUES add example of OnewayProducer and ScheduledMessage #3048]add example of OnewayProducer and ScheduledMessage

add the example for OnewayProducer and ScheduledMessageConsumer.
remove a unused line and add notes.
@coveralls
Copy link

coveralls commented Jun 23, 2021

Coverage Status

Coverage increased (+0.07%) to 54.152% when pulling c4cde2e on zplovekq:dev_simple_code into 160c577 on apache:develop.

@zplovekq zplovekq changed the title [ISSUE #3048]Dev simple code for schedule msg and send-one-way producer [ISSUES #3048]Dev simple code for schedule msg and send-one-way producer Jun 28, 2021
@zplovekq zplovekq changed the title [ISSUES #3048]Dev simple code for schedule msg and send-one-way producer [ISSUES #3048]add example of OnewayProducer and ScheduledMessage Jun 28, 2021
@duhenglucky
Copy link
Contributor

@zplovekq waiting for your fix to make the CI. passed

@zplovekq
Copy link
Contributor Author

zplovekq commented Aug 4, 2021

@zplovekq waiting for your fix to make the CI. passed

thanks! i am fixing it !

@zplovekq
Copy link
Contributor Author

zplovekq commented Aug 4, 2021

@zplovekq waiting for your fix to make the CI. passed

I find the CI is not passed because of the maven_code_style_plugin. I have fixed these problems by idea checkstyle plugin with style/rmq_checkstyle.xml. Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #3053 (c4cde2e) into develop (df1d93f) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3053      +/-   ##
=============================================
- Coverage      47.97%   47.87%   -0.11%     
+ Complexity      4570     4551      -19     
=============================================
  Files            552      552              
  Lines          36628    36521     -107     
  Branches        4844     4818      -26     
=============================================
- Hits           17573    17485      -88     
+ Misses         16832    16818      -14     
+ Partials        2223     2218       -5     
Impacted Files Coverage Δ
.../broker/subscription/SubscriptionGroupManager.java 54.11% <0.00%> (-16.48%) ⬇️
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-13.05%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-12.78%) ⬇️
...rocketmq/broker/pagecache/ManyMessageTransfer.java 36.36% <0.00%> (-9.80%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
.../rocketmq/broker/pagecache/OneMessageTransfer.java 24.00% <0.00%> (-9.34%) ⬇️
...a/org/apache/rocketmq/logging/inner/SysLogger.java 28.57% <0.00%> (-5.72%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-5.00%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-4.48%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df1d93f...c4cde2e. Read the comment docs.

@duhenglucky duhenglucky merged commit 8fdfb42 into apache:develop Jan 24, 2022
@duhenglucky duhenglucky added this to the 4.9.3 milestone Jan 24, 2022
@francisoliverlee francisoliverlee changed the title [ISSUES #3048]add example of OnewayProducer and ScheduledMessage [ISSUE #3048]add example of OnewayProducer and ScheduledMessage Feb 21, 2022
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
apache#3053)

* fix the issue apache#2994
add the example for OnewayProducer and ScheduledMessageConsumer.
remove a unused line and add notes.

* rollback

* change code style

* modify the code style

Co-authored-by: zoupeinie <zoupeinie@bytedance.com>
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
apache#3053)

* fix the issue apache#2994
add the example for OnewayProducer and ScheduledMessageConsumer.
remove a unused line and add notes.

* rollback

* change code style

* modify the code style

Co-authored-by: zoupeinie <zoupeinie@bytedance.com>
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
apache#3053)

* fix the issue apache#2994
add the example for OnewayProducer and ScheduledMessageConsumer.
remove a unused line and add notes.

* rollback

* change code style

* modify the code style

Co-authored-by: zoupeinie <zoupeinie@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants