Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3123]fix namesrv endpoint #3122

Merged
merged 1 commit into from
Jul 13, 2021
Merged

[ISSUE #3123]fix namesrv endpoint #3122

merged 1 commit into from
Jul 13, 2021

Conversation

panzhi33
Copy link
Contributor

@panzhi33 panzhi33 commented Jul 2, 2021

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@panzhi33 panzhi33 changed the title fix namesrv endpoint [ISSUE #3123]fix namesrv endpoint Jul 2, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 54.185% when pulling f4b3d4f on panzhi33:master into 9a5ec90 on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 54.185% when pulling f4b3d4f on panzhi33:master into 9a5ec90 on apache:develop.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2021

Codecov Report

Merging #3122 (f4b3d4f) into develop (df1d93f) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3122      +/-   ##
=============================================
- Coverage      47.97%   47.96%   -0.02%     
+ Complexity      4570     4559      -11     
=============================================
  Files            552      552              
  Lines          36628    36638      +10     
  Branches        4844     4845       +1     
=============================================
  Hits           17573    17573              
- Misses         16832    16836       +4     
- Partials        2223     2229       +6     
Impacted Files Coverage Δ
.../java/org/apache/rocketmq/client/ClientConfig.java 59.39% <0.00%> (ø)
.../rocketmq/common/utils/NameServerAddressUtils.java 45.45% <100.00%> (+5.45%) ⬆️
.../org/apache/rocketmq/store/PutMessageSpinLock.java 0.00% <0.00%> (-85.72%) ⬇️
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 43.47% <0.00%> (-8.70%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 71.15% <0.00%> (-7.70%) ⬇️
...a/org/apache/rocketmq/logging/inner/SysLogger.java 28.57% <0.00%> (-5.72%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-5.00%) ⬇️
...ketmq/client/impl/consumer/PullMessageService.java 75.55% <0.00%> (-4.45%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df1d93f...f4b3d4f. Read the comment docs.

@vongosling vongosling linked an issue Jul 5, 2021 that may be closed by this pull request
@zongtanghu zongtanghu added this to the 4.9.1 milestone Jul 6, 2021
@duhenglucky duhenglucky merged commit 3efcd85 into apache:develop Jul 13, 2021
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix namesrv endpoint
5 participants