-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #3284]Optimize the buildMessage method #3324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3324 +/- ##
=============================================
+ Coverage 48.01% 48.06% +0.04%
- Complexity 4562 4563 +1
=============================================
Files 552 552
Lines 36538 36538
Branches 4822 4822
=============================================
+ Hits 17543 17561 +18
+ Misses 16777 16760 -17
+ Partials 2218 2217 -1
Continue to review full report at Codecov.
|
Please help to review it. @areyouok |
zongtanghu
approved these changes
Sep 7, 2021
@areyouok please review it. |
areyouok
approved these changes
Sep 8, 2021
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
* [ISSUE apache#3284]Optimize the buildMessage method Co-authored-by: zhangjidi2016 <zhangjidi@cmss.chinamobile.com>
carlvine500
pushed a commit
to carlvine500/rocketmq-apache
that referenced
this pull request
Sep 10, 2024
* [ISSUE apache#3284]Optimize the buildMessage method Co-authored-by: zhangjidi2016 <zhangjidi@cmss.chinamobile.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
develop
What is the purpose of the change
#3284
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.