Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3284]Optimize the buildMessage method #3324

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

zhangjidi2016
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

#3284

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

coveralls commented Sep 7, 2021

Coverage Status

Coverage decreased (-0.08%) to 54.151% when pulling d085c61 on zhangjidi2016:optimize_buildMessage into d7a830c on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3324 (caba786) into develop (d7a830c) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3324      +/-   ##
=============================================
+ Coverage      48.01%   48.06%   +0.04%     
- Complexity      4562     4563       +1     
=============================================
  Files            552      552              
  Lines          36538    36538              
  Branches        4822     4822              
=============================================
+ Hits           17543    17561      +18     
+ Misses         16777    16760      -17     
+ Partials        2218     2217       -1     
Impacted Files Coverage Δ
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 71.42% <0.00%> (-5.36%) ⬇️
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 48.52% <0.00%> (-1.48%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 39.45% <0.00%> (-0.79%) ⬇️
...org/apache/rocketmq/store/DefaultMessageStore.java 55.34% <0.00%> (-0.51%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
...ketmq/client/impl/consumer/PullMessageService.java 75.55% <0.00%> (ø)
.../apache/rocketmq/logging/inner/LoggingBuilder.java 63.92% <0.00%> (+0.31%) ⬆️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 59.53% <0.00%> (+0.46%) ⬆️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 40.17% <0.00%> (+0.52%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a830c...caba786. Read the comment docs.

@zhangjidi2016
Copy link
Contributor Author

Please help to review it. @areyouok

@zongtanghu
Copy link
Contributor

@areyouok please review it.

@areyouok areyouok merged commit fea769d into apache:develop Sep 8, 2021
@zhangjidi2016 zhangjidi2016 deleted the optimize_buildMessage branch April 14, 2022 13:30
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
* [ISSUE apache#3284]Optimize the buildMessage method

Co-authored-by: zhangjidi2016 <zhangjidi@cmss.chinamobile.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants