Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#3983] Duplicated warn log in class DefaultMQProducerImpl is unnecessary. #3984

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

XiaoyiPeng
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

For #3983

Brief changelog

Remove duplicated warn log in class DefaultMQProducerImpl.

Verifying this change

XXXX

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #3984 (bed2b3c) into develop (40d9505) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3984      +/-   ##
=============================================
+ Coverage      47.68%   47.71%   +0.02%     
  Complexity      4972     4972              
=============================================
  Files            633      633              
  Lines          42579    42577       -2     
  Branches        5589     5589              
=============================================
+ Hits           20305    20315      +10     
+ Misses         19764    19754      -10     
+ Partials        2510     2508       -2     
Impacted Files Coverage Δ
...mq/client/impl/producer/DefaultMQProducerImpl.java 45.59% <ø> (+0.48%) ⬆️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 59.13% <0.00%> (-2.16%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 36.97% <0.00%> (-0.57%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.79% <0.00%> (-0.52%) ⬇️
...ain/java/org/apache/rocketmq/store/MappedFile.java 51.40% <0.00%> (-0.36%) ⬇️
...etmq/client/latency/LatencyFaultToleranceImpl.java 50.00% <0.00%> (ø)
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 44.44% <0.00%> (+5.55%) ⬆️
...org/apache/rocketmq/common/stats/StatsItemSet.java 52.23% <0.00%> (+8.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d9505...bed2b3c. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 51.77% when pulling bed2b3c on XiaoyiPeng:fix_duplicated_warn_log into 895bd95 on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 51.77% when pulling bed2b3c on XiaoyiPeng:fix_duplicated_warn_log into 895bd95 on apache:develop.

@yuz10 yuz10 merged commit 2b51321 into apache:develop Mar 14, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants