Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4050] fix origin messsage id missing from dead leetter meessage #4051

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

Git-Yang
Copy link
Member

What is the purpose of the change

Fix #4050

Brief changelog

XX

Verifying this change

image

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

…meessage

Signed-off-by: zhangyang21 <zhangyang21@xiaomi.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #4051 (30ed6c6) into develop (818ef21) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4051      +/-   ##
=============================================
- Coverage      47.93%   47.85%   -0.08%     
+ Complexity      5002     4989      -13     
=============================================
  Files            633      633              
  Lines          42528    42528              
  Branches        5573     5573              
=============================================
- Hits           20386    20352      -34     
- Misses         19648    19678      +30     
- Partials        2494     2498       +4     
Impacted Files Coverage Δ
...nt/impl/consumer/ConsumeMessageOrderlyService.java 49.64% <0.00%> (-0.71%) ⬇️
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) ⬇️
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 40.17% <0.00%> (-2.29%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 60.43% <0.00%> (-2.20%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-1.80%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 79.70% <0.00%> (-1.49%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 72.05% <0.00%> (-1.48%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 43.75% <0.00%> (-0.79%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 818ef21...30ed6c6. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 51.902% when pulling 30ed6c6 on Git-Yang:client_bug_fix into 818ef21 on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 51.902% when pulling 30ed6c6 on Git-Yang:client_bug_fix into 818ef21 on apache:develop.

@Git-Yang Git-Yang merged commit 45010d9 into apache:develop Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Client] OriginMessageId missing from dead letter message
4 participants