Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4050] 5.0.0-alpha (Pop): Missing origin message id from dead letter message #4052

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

Git-Yang
Copy link
Member

What is the purpose of the change

Fix #4050

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

…inMessageId

Signed-off-by: zhangyang21 <zhangyang21@xiaomi.com>
…meessage

Signed-off-by: zhangyang21 <zhangyang21@xiaomi.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 49.435% when pulling 42d5422 on Git-Yang:client_bug_fix_v2 into a17fa76 on apache:5.0.0-alpha.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 49.435% when pulling 42d5422 on Git-Yang:client_bug_fix_v2 into a17fa76 on apache:5.0.0-alpha.

@codecov-commenter
Copy link

Codecov Report

Merging #4052 (42d5422) into 5.0.0-alpha (a17fa76) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@                Coverage Diff                @@
##             5.0.0-alpha    #4052      +/-   ##
=================================================
- Coverage          45.38%   45.33%   -0.05%     
+ Complexity          5600     5592       -8     
=================================================
  Files                722      722              
  Lines              50531    50531              
  Branches            6927     6927              
=================================================
- Hits               22932    22907      -25     
- Misses             24642    24666      +24     
- Partials            2957     2958       +1     
Impacted Files Coverage Δ
...nt/impl/consumer/ConsumeMessageOrderlyService.java 44.91% <0.00%> (ø)
...impl/consumer/ConsumeMessagePopOrderlyService.java 10.00% <0.00%> (ø)
...apache/rocketmq/broker/longpolling/PopRequest.java 31.03% <0.00%> (-13.80%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 59.13% <0.00%> (-2.16%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 71.42% <0.00%> (-1.79%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 77.22% <0.00%> (-1.49%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 45.58% <0.00%> (-1.39%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
...etmq/client/latency/LatencyFaultToleranceImpl.java 50.00% <0.00%> (-1.29%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a17fa76...42d5422. Read the comment docs.

@Git-Yang Git-Yang linked an issue Mar 29, 2022 that may be closed by this pull request
@RongtongJin
Copy link
Contributor

Hi @Git-Yang 5.0-alpha has been released, should change to target branch to 5.0-beta.

@RongtongJin RongtongJin changed the base branch from 5.0.0-alpha to 5.0.0-beta March 29, 2022 11:41
@Git-Yang
Copy link
Member Author

Hi @Git-Yang 5.0-alpha has been released, should change to target branch to 5.0-beta.

👌

@RongtongJin RongtongJin merged commit d99a51c into apache:5.0.0-beta Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Client] OriginMessageId missing from dead letter message
4 participants