-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Summer of code] Let broker send heartbeat to controller #4341
[Summer of code] Let broker send heartbeat to controller #4341
Conversation
Codecov Report
@@ Coverage Diff @@
## 5.0.0-beta-dledger-controller #4341 +/- ##
===================================================================
- Coverage 43.55% 43.47% -0.09%
+ Complexity 6319 6310 -9
===================================================================
Files 835 835
Lines 59199 59285 +86
Branches 8068 8082 +14
===================================================================
- Hits 25787 25777 -10
- Misses 30091 30177 +86
- Partials 3321 3331 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the controller is deployed independently, we do not send heartbeat to the namesrv.
What is the purpose of the change
tracking issue: #4330
Brief changelog
When the controller is deployed independently, let the broker send the heartbeat to the controller.
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.