Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Summer of code] Let broker send heartbeat to controller #4341

Conversation

hzh0425
Copy link
Member

@hzh0425 hzh0425 commented May 19, 2022

What is the purpose of the change

tracking issue: #4330

Brief changelog

When the controller is deployed independently, let the broker send the heartbeat to the controller.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@hzh0425 hzh0425 mentioned this pull request May 19, 2022
12 tasks
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #4341 (39fbeeb) into 5.0.0-beta-dledger-controller (4e9e4e3) will decrease coverage by 0.08%.
The diff coverage is 9.35%.

@@                         Coverage Diff                         @@
##             5.0.0-beta-dledger-controller    #4341      +/-   ##
===================================================================
- Coverage                            43.55%   43.47%   -0.09%     
+ Complexity                            6319     6310       -9     
===================================================================
  Files                                  835      835              
  Lines                                59199    59285      +86     
  Branches                              8068     8082      +14     
===================================================================
- Hits                                 25787    25777      -10     
- Misses                               30091    30177      +86     
- Partials                              3321     3331      +10     
Impacted Files Coverage Δ
.../rocketmq/broker/hacontroller/ReplicasManager.java 0.00% <0.00%> (ø)
...org/apache/rocketmq/broker/out/BrokerOuterAPI.java 19.25% <0.00%> (-0.61%) ⬇️
...he/rocketmq/common/protocol/body/SyncStateSet.java 0.00% <0.00%> (ø)
...amesrv/controller/GetReplicaInfoRequestHeader.java 0.00% <0.00%> (ø)
...mesrv/controller/GetReplicaInfoResponseHeader.java 0.00% <0.00%> (ø)
...ache/rocketmq/container/InnerBrokerController.java 44.00% <0.00%> (ø)
...ache/rocketmq/store/config/MessageStoreConfig.java 55.82% <ø> (-0.36%) ⬇️
...a/org/apache/rocketmq/broker/BrokerController.java 47.84% <2.56%> (-0.73%) ⬇️
.../java/org/apache/rocketmq/common/BrokerConfig.java 28.23% <25.00%> (-0.06%) ⬇️
...e/rocketmq/controller/impl/manager/BrokerInfo.java 81.25% <33.33%> (-11.61%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9e4e3...39fbeeb. Read the comment docs.

@coveralls
Copy link

coveralls commented May 19, 2022

Coverage Status

Coverage increased (+0.02%) to 47.665% when pulling 39fbeeb on hzh0425:feature/broker-sendheartbeat-to-controller into 4e9e4e3 on apache:5.0.0-beta-dledger-controller.

Copy link
Contributor

@RongtongJin RongtongJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the controller is deployed independently, we do not send heartbeat to the namesrv.

@RongtongJin RongtongJin merged commit f905da4 into apache:5.0.0-beta-dledger-controller May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants