Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement MQClientInstance #7402 #7405

Closed

Conversation

shirenchuang
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7402

Brief Description

How Did You Test This Change?

通过判断consumerTable的数量判断是否有消费者存在

  1. 在初次启动的时候,如果是注册的消费者,则直接将那几个服务启动,否则不启动
  2. 如果初次启动不是消费者,但是后续有加入新的消费者,则判断那几个服务是否已经启动,如果没有则启动

Determine whether there are consumers by judging the number of consumerTables

  1. At the initial startup, if it is a registered consumer, directly start those services, otherwise it will not start.
  2. If the initial startup is not a consumer, but new consumers are added later, determine whether those services have been started, and if not, start them

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Merging #7405 (13f1c06) into develop (0a6ae46) will increase coverage by 0.04%.
The diff coverage is 90.90%.

@@              Coverage Diff              @@
##             develop    #7405      +/-   ##
=============================================
+ Coverage      42.62%   42.66%   +0.04%     
- Complexity      9462     9475      +13     
=============================================
  Files           1150     1150              
  Lines          82750    82758       +8     
  Branches       10779    10781       +2     
=============================================
+ Hits           35269    35311      +42     
+ Misses         43053    43025      -28     
+ Partials        4428     4422       -6     
Files Coverage Δ
...mq/client/impl/producer/DefaultMQProducerImpl.java 45.31% <100.00%> (+0.40%) ⬆️
...rocketmq/client/impl/factory/MQClientInstance.java 47.07% <87.50%> (+0.23%) ⬆️

... and 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Oct 7, 2024

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

@github-actions github-actions bot added the stale label Oct 7, 2024
Copy link

This PR was closed because it has been inactive for 3 days since being marked as stale.

@github-actions github-actions bot closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Enhancement MQClientInstance
3 participants