[ISSUE #8254]Fix runtime modifications to semaphoreAsyncSendNum and semaphoreAsyncSendSize result in inaccurate actual semaphore values #8257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us message sending back pressure
…us message sending back pressure
…us message sending back pressure
…2656/rocketmq into fix_producer_backcompress # Conflicts: # client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
…maphore calculations
…SendSize result in inaccurate actual semaphore values
…SendSize result in inaccurate actual semaphore values
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8257 +/- ##
=============================================
+ Coverage 42.84% 42.86% +0.02%
- Complexity 10395 10406 +11
=============================================
Files 1274 1275 +1
Lines 88943 89009 +66
Branches 11438 11442 +4
=============================================
+ Hits 38109 38157 +48
- Misses 46119 46133 +14
- Partials 4715 4719 +4 ☔ View full report in Codecov by Sentry. |
GenerousMan
approved these changes
Jun 5, 2024
|
@RongtongJin PTAL~ |
RongtongJin
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8254
Fixes #8140
Brief Description
How Did You Test This Change?