Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8298] optimize some code format or style #8299

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

supervate
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8298

Brief Description

How Did You Test This Change?

@ShannonDing ShannonDing added the soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on label Jun 14, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 55.55556% with 28 lines in your changes missing coverage. Please review.

Project coverage is 42.88%. Comparing base (38c56cd) to head (d613974).

Files Patch % Lines
...org/apache/rocketmq/broker/out/BrokerOuterAPI.java 15.38% 11 Missing ⚠️
...c/main/java/org/apache/rocketmq/common/MixAll.java 22.22% 6 Missing and 1 partial ⚠️
...che/rocketmq/acl/plain/PlainPermissionManager.java 86.66% 0 Missing and 4 partials ⚠️
...ketmq/proxy/service/route/ProxyTopicRouteData.java 50.00% 4 Missing ⚠️
...rocketmq/common/config/AbstractRocksDBStorage.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #8299   +/-   ##
==========================================
  Coverage      42.87%   42.88%           
- Complexity     10399    10408    +9     
==========================================
  Files           1274     1274           
  Lines          88943    88934    -9     
  Branches       11438    11433    -5     
==========================================
  Hits           38137    38137           
+ Misses         46093    46091    -2     
+ Partials        4713     4706    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin
Copy link
Contributor

LGTM~

@RongtongJin RongtongJin merged commit 77d6633 into apache:develop Jul 4, 2024
10 checks passed
@ShannonDing
Copy link
Member

link #8262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] optimize some code format or style
4 participants