SAMZA-2386: Get store names should return correct store names in the presence of side inputs #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…presence of side inputs
|
@mynameborat Thanks for the quick fix. @rmatharu Can you review and merge? |
rmatharu-zz
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symptom: Enabling side inputs for low level jobs using configuration will throw an exception during job start up.
Cause:
getStoreNames()uses pattern matching to infer store names from the config. The pattern matching conflicts withside.inputs.processor.factoryand returns incorrect store names.Fix: Handle side inputs processors factory prefix correctly within
getStoreNames()Tests: Added unit test for
getStoreNames()API Change: None
Usage Instructions: None
Upgrade Instructions: None