SAMZA-2452 : Adding internal autosizing related configs #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmatharu-zz
requested review from
prateekm and
cameronlee314
and removed request for
prateekm
|
@cameronlee314 @abhishekshivanna can you review? |
samza-core/src/main/java/org/apache/samza/config/ClusterManagerConfig.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/config/ClusterManagerConfig.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/config/JobConfig.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/config/JobConfig.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/config/JobConfig.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/scala/org/apache/samza/util/CoordinatorStreamUtil.scala
Show resolved
Hide resolved
samza-core/src/main/scala/org/apache/samza/config/ShellCommandConfig.scala
Show resolved
Hide resolved
|
Can you please add a JIRA ticket to the PR and add an "API changes" section to the description (see https://cwiki.apache.org/confluence/display/SAMZA/SEP-25%3A+PR+Title+And+Description+Guidelines)? |
rmatharu-zz
changed the title
|
Addressed all comments, please take a look |
cameronlee314
approved these changes
Feb 4, 2020
Comment on lines
639
to
643
| // opts set without -Xmx, autosizing max heap set | ||
| shellCommandConfig = new ShellCommandConfig(new MapConfig( | ||
| ImmutableMap.of(JobConfig.JOB_AUTOSIZING_ENABLED, "true", JobConfig.JOB_AUTOSIZING_CONTAINER_MAX_HEAP_MB, | ||
| "1024"))); | ||
| assertEquals(Option.apply("-Xmx1024m"), shellCommandConfig.getTaskOpts()); |
There was a problem hiding this comment.
I think this section is the same as the block above. Seems like the code doesn't match the comment.
There was a problem hiding this comment.
- I saw your change, but I meant to refer to the lines immediately above this. I think this code block needs to be changed (not removed) to have a non-empty opts that doesn't have an -Xmx param.
- I would also suggest adding a test in which opts has -Xmx but needs to be replaced by the autosizing config.
abhishekshivanna
approved these changes
Feb 5, 2020
There was a problem hiding this comment.
Nothing to add on to what @cameronlee314 already mentioned. LGTM.
| @@ -130,6 +130,15 @@ | |||
| public static final String CONTAINER_METADATA_FILENAME_FORMAT = "%s.metadata"; // Filename: <containerID>.metadata | |||
| public static final String CONTAINER_METADATA_DIRECTORY_SYS_PROPERTY = "samza.log.dir"; | |||
|
|
|||
| // Auto-sizing related configs tthat ake precedence over respective sizing confings job.container.count, etc, | |||
There was a problem hiding this comment.
nit: typo tthat ake
There was a problem hiding this comment.
It looks like you still have a typo ("that ake") after your last change.
Comment on lines
613
to
617
|
|
||
| String taskOpts = "-Dproperty=value"; | ||
| shellCommandConfig = new ShellCommandConfig(new MapConfig( | ||
| ImmutableMap.of(ShellCommandConfig.TASK_JVM_OPTS(), taskOpts, JobConfig.JOB_AUTOSIZING_ENABLED, "false"))); | ||
| assertEquals(Option.apply(taskOpts), shellCommandConfig.getTaskOpts()); |
There was a problem hiding this comment.
I don't think this should be removed. It is actually a different test case (i.e. autosizing is disabled).
cameronlee314
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding internal autosizing related configs, can be used by an external controller.
These sizing-related configs (e.g., container-count, etc) take precedence when job.autosizing.enabled is set, otherwise existing behavior is retained.
Symptom: Sizing configs set by a controller need to be different from user-facing configs.
Cause: --
Fix: Added internal configs for sizing related configs. Added tests.
The enabled config is also needs to be emitted by the DiagnosticsManager.
API Changes: Adding internal autosizing related configs (job.autosizing.enabled, job.autosizing.container.count, job.autosizing.container.thread.pool.size, job.autosizing.maxheap.mb, job.autosizing.cpu.cores) , can be used by an external controller. These sizing-related configs (e.g., container-count, etc) take precedence when job.autosizing.enabled is set, otherwise existing behavior is retained.