Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMZA-1428: Fix scala 2.10 compilation issue with java 8 interface st… #300

Closed
wants to merge 1 commit into from

Conversation

jmakes
Copy link
Contributor

@jmakes jmakes commented Sep 21, 2017

…atic methods

@jmakes
Copy link
Contributor Author

jmakes commented Sep 21, 2017

@sborya take a look!

Also, because of the PR number, I gotta say:
"THIS.... IS.... SPARTA!!!!"

@sborya
Copy link
Contributor

sborya commented Sep 21, 2017

And because yesterday was a "Speak as a pirate day" you should say:
"This .. is .. SPARRRRRTA!!!

Copy link
Contributor

@sborya sborya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@asfgit asfgit closed this in 987180a Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants