Skip to content

Commit 3c0415e

Browse files
authored
Replace plain string with constants (#2308)
1 parent 12ebcb4 commit 3c0415e

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

seatunnel-common/src/main/java/org/apache/seatunnel/common/Constants.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ public final class Constants {
4141

4242
public static final String CHECKPOINT_ID = "checkpoint.id";
4343

44+
public static final String UUID = "uuid";
45+
46+
public static final String NOW = "now";
47+
4448
private Constants() {
4549
}
4650
}

seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/VariablesSubstitute.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717

1818
package org.apache.seatunnel.common.utils;
1919

20+
import org.apache.seatunnel.common.Constants;
21+
2022
import org.apache.commons.lang3.text.StrSubstitutor;
2123

2224
import java.time.ZonedDateTime;
@@ -40,8 +42,8 @@ public static String substitute(String text, String timeFormat) {
4042
final String formattedDate = df.format(ZonedDateTime.now());
4143

4244
final Map<String, String> valuesMap = new HashMap<>(3);
43-
valuesMap.put("uuid", UUID.randomUUID().toString());
44-
valuesMap.put("now", formattedDate);
45+
valuesMap.put(Constants.UUID, UUID.randomUUID().toString());
46+
valuesMap.put(Constants.NOW, formattedDate);
4547
valuesMap.put(timeFormat, formattedDate);
4648
return substitute(text, valuesMap);
4749
}

seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/FileSinkTransactionFileNameGenerator.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
package org.apache.seatunnel.connectors.seatunnel.file.sink.writer;
1919

20+
import org.apache.seatunnel.common.Constants;
2021
import org.apache.seatunnel.common.utils.VariablesSubstitute;
2122
import org.apache.seatunnel.connectors.seatunnel.file.config.Constant;
2223
import org.apache.seatunnel.connectors.seatunnel.file.config.FileFormat;
@@ -57,8 +58,8 @@ public String generateFileName(String transactionId) {
5758
final String formattedDate = df.format(ZonedDateTime.now());
5859

5960
final Map<String, String> valuesMap = new HashMap<>(4);
60-
valuesMap.put("uuid", UUID.randomUUID().toString());
61-
valuesMap.put("now", formattedDate);
61+
valuesMap.put(Constants.UUID, UUID.randomUUID().toString());
62+
valuesMap.put(Constants.NOW, formattedDate);
6263
valuesMap.put(timeFormat, formattedDate);
6364
valuesMap.put(Constant.TRANSACTION_EXPRESSION, transactionId);
6465
String substitute = VariablesSubstitute.substitute(fileNameExpression, valuesMap);

0 commit comments

Comments
 (0)