Skip to content

Commit 5376905

Browse files
authored
Shade google common in hadoop (#4222)
1 parent a3fe367 commit 5376905

File tree

3 files changed

+16
-5
lines changed
  • seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/client
  • seatunnel-core/seatunnel-starter/src/main/java/org/apache/seatunnel/core/starter/seatunnel/command
  • seatunnel-shade/seatunnel-hadoop3-3.1.4-uber

3 files changed

+16
-5
lines changed

seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/client/EsRestClient.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -442,9 +442,13 @@ public Map<String, String> getFieldTypeMapping(String index, List<String> source
442442
JsonNode properties = mappingsProperty.get("properties");
443443
mapping = getFieldTypeMappingFromProperties(properties, source);
444444
} else {
445-
for (Iterator<JsonNode> iter = mappingsProperty.iterator(); iter.hasNext(); ) {
446-
JsonNode typeNode = iter.next();
447-
JsonNode properties = typeNode.get("properties");
445+
for (JsonNode typeNode : mappingsProperty) {
446+
JsonNode properties;
447+
if (typeNode.has("properties")) {
448+
properties = typeNode.get("properties");
449+
} else {
450+
properties = typeNode;
451+
}
448452
mapping.putAll(getFieldTypeMappingFromProperties(properties, source));
449453
}
450454
}
@@ -457,7 +461,6 @@ public Map<String, String> getFieldTypeMapping(String index, List<String> source
457461
}
458462

459463
private static Map<String, String> getFieldTypeMappingFromProperties(JsonNode properties, List<String> source) {
460-
Map<String, String> mapping = new HashMap<>();
461464
Map<String, String> allElasticSearchFieldTypeInfoMap = new HashMap<>();
462465
properties.fields().forEachRemaining(entry -> {
463466
String fieldName = entry.getKey();

seatunnel-core/seatunnel-starter/src/main/java/org/apache/seatunnel/core/starter/seatunnel/command/ClientExecuteCommand.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import org.apache.seatunnel.engine.core.job.JobStatus;
3737
import org.apache.seatunnel.engine.server.SeaTunnelNodeContext;
3838

39+
import com.google.common.util.concurrent.ThreadFactoryBuilder;
3940
import com.hazelcast.client.config.ClientConfig;
4041
import com.hazelcast.core.HazelcastInstance;
4142
import com.hazelcast.instance.impl.HazelcastInstanceFactory;
@@ -126,7 +127,10 @@ public void execute() throws CommandExecuteException {
126127
// get job id
127128
long jobId = clientJobProxy.getJobId();
128129
JobMetricsRunner jobMetricsRunner = new JobMetricsRunner(engineClient, jobId);
129-
executorService = Executors.newSingleThreadScheduledExecutor();
130+
executorService = Executors.newSingleThreadScheduledExecutor(new ThreadFactoryBuilder()
131+
.setNameFormat("job-metrics-runner-%d")
132+
.setDaemon(true)
133+
.build());
130134
executorService.scheduleAtFixedRate(jobMetricsRunner, 0,
131135
seaTunnelConfig.getEngineConfig().getPrintJobMetricsInfoInterval(), TimeUnit.SECONDS);
132136
// wait for job complete
@@ -141,12 +145,15 @@ public void execute() throws CommandExecuteException {
141145
} finally {
142146
if (engineClient != null) {
143147
engineClient.close();
148+
log.info("Closed SeaTunnel client......");
144149
}
145150
if (instance != null) {
146151
instance.shutdown();
152+
log.info("Closed HazelcastInstance ......");
147153
}
148154
if (executorService != null) {
149155
executorService.shutdown();
156+
log.info("Closed metrics executor service ......");
150157
}
151158
if (jobMetricsSummary != null) {
152159
// print job statistics information when job finished

seatunnel-shade/seatunnel-hadoop3-3.1.4-uber/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@
9292
<includes>
9393
<include>com.google.common.base.*</include>
9494
<include>com.google.common.cache.*</include>
95+
<include>com.google.common.collect.*</include>
9596
</includes>
9697
</relocation>
9798
<relocation>

0 commit comments

Comments
 (0)