Skip to content

Commit 53f0a9e

Browse files
[Fix][Connector-V2] Fix StarRocksCatalogTest#testCatalog() NPE (#8987)
1 parent 9204f28 commit 53f0a9e

File tree

3 files changed

+11
-87
lines changed
  • seatunnel-connectors-v2/connector-starrocks/src
  • seatunnel-e2e/seatunnel-connector-v2-e2e/connector-starrocks-e2e/src/test/java/org/apache/seatunnel/e2e/connector/starrocks

3 files changed

+11
-87
lines changed

seatunnel-connectors-v2/connector-starrocks/src/main/java/org/apache/seatunnel/connectors/seatunnel/starrocks/client/StarRocksStreamLoadVisitor.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ public class StarRocksStreamLoadVisitor {
5252
private static final String RESULT_FAILED = "Fail";
5353
private static final String RESULT_SUCCESS = "Success";
5454
private static final String RESULT_LABEL_EXISTED = "Label Already Exists";
55-
private static final String LAEBL_STATE_VISIBLE = "VISIBLE";
56-
private static final String LAEBL_STATE_COMMITTED = "COMMITTED";
55+
private static final String LABEL_STATE_VISIBLE = "VISIBLE";
56+
private static final String LABEL_STATE_COMMITTED = "COMMITTED";
5757
private static final String RESULT_LABEL_PREPARE = "PREPARE";
5858
private static final String RESULT_LABEL_ABORTED = "ABORTED";
5959
private static final String RESULT_LABEL_UNKNOWN = "UNKNOWN";
@@ -225,8 +225,8 @@ private void checkLabelState(String host, String label) throws IOException {
225225
}
226226
LOG.info(String.format("Checking label[%s] state[%s]\n", label, labelState));
227227
switch (labelState) {
228-
case LAEBL_STATE_VISIBLE:
229-
case LAEBL_STATE_COMMITTED:
228+
case LABEL_STATE_VISIBLE:
229+
case LABEL_STATE_COMMITTED:
230230
return;
231231
case RESULT_LABEL_PREPARE:
232232
continue;

seatunnel-connectors-v2/connector-starrocks/src/test/java/org/apache/seatunnel/connectors/seatunnel/starrocks/catalog/StarRocksCatalogTest.java

Lines changed: 0 additions & 83 deletions
This file was deleted.

seatunnel-e2e/seatunnel-connector-v2-e2e/connector-starrocks-e2e/src/test/java/org/apache/seatunnel/e2e/connector/starrocks/StarRocksIT.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -421,6 +421,13 @@ public void testCatalog() {
421421
String.format(URL, starRocksServer.getHost()),
422422
"CREATE TABLE IF NOT EXISTS `${database}`.`${table}` (\n ${rowtype_fields}\n ) ENGINE=OLAP \n DUPLICATE KEY(`BIGINT_COL`) \n COMMENT '${comment}' \n DISTRIBUTED BY HASH (BIGINT_COL) BUCKETS 1 \n PROPERTIES (\n \"replication_num\" = \"1\", \n \"in_memory\" = \"false\" , \n \"storage_format\" = \"DEFAULT\" \n )");
423423
starRocksCatalog.open();
424+
425+
String tmpDB = "test_tmp";
426+
if (!starRocksCatalog.databaseExists(tmpDB)) {
427+
starRocksCatalog.createDatabase(TablePath.of(tmpDB, "default"), true);
428+
}
429+
Assertions.assertTrue(starRocksCatalog.listDatabases().contains(tmpDB));
430+
424431
CatalogTable catalogTable = starRocksCatalog.getTable(tablePathStarRocksSource);
425432
catalogTable =
426433
CatalogTable.of(

0 commit comments

Comments
 (0)