Skip to content

Commit bbedb07

Browse files
lightzhaolightzhao
authored
[Improve]Change System.out.println to log output. (#5912)
1 parent d757dcd commit bbedb07

File tree

10 files changed

+47
-25
lines changed

10 files changed

+47
-25
lines changed

‎seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/writer/OrcReadStrategyTest.java‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
import org.junit.jupiter.api.Assertions;
3030
import org.junit.jupiter.api.Test;
3131

32+
import lombok.extern.slf4j.Slf4j;
33+
3234
import java.io.File;
3335
import java.net.URL;
3436
import java.nio.file.Paths;
@@ -37,6 +39,7 @@
3739

3840
import static org.apache.hadoop.fs.CommonConfigurationKeysPublic.FS_DEFAULT_NAME_DEFAULT;
3941

42+
@Slf4j
4043
public class OrcReadStrategyTest {
4144

4245
@Test
@@ -51,7 +54,7 @@ public void testOrcRead() throws Exception {
5154
SeaTunnelRowType seaTunnelRowTypeInfo =
5255
orcReadStrategy.getSeaTunnelRowTypeInfo(localConf, orcFilePath);
5356
Assertions.assertNotNull(seaTunnelRowTypeInfo);
54-
System.out.println(seaTunnelRowTypeInfo);
57+
log.info(seaTunnelRowTypeInfo.toString());
5558
orcReadStrategy.read(orcFilePath, "", testCollector);
5659
for (SeaTunnelRow row : testCollector.getRows()) {
5760
Assertions.assertEquals(row.getField(0).getClass(), Boolean.class);
@@ -77,7 +80,7 @@ public void testOrcReadProjection() throws Exception {
7780
SeaTunnelRowType seaTunnelRowTypeInfo =
7881
orcReadStrategy.getSeaTunnelRowTypeInfo(localConf, orcFilePath);
7982
Assertions.assertNotNull(seaTunnelRowTypeInfo);
80-
System.out.println(seaTunnelRowTypeInfo);
83+
log.info(seaTunnelRowTypeInfo.toString());
8184
orcReadStrategy.read(orcFilePath, "", testCollector);
8285
for (SeaTunnelRow row : testCollector.getRows()) {
8386
Assertions.assertEquals(row.getField(0).getClass(), Byte.class);
@@ -95,7 +98,7 @@ public List<SeaTunnelRow> getRows() {
9598

9699
@Override
97100
public void collect(SeaTunnelRow record) {
98-
System.out.println(record);
101+
log.info(record.toString());
99102
rows.add(record);
100103
}
101104

‎seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/writer/ParquetReadStrategyTest.java‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
import org.junit.jupiter.api.Assertions;
3030
import org.junit.jupiter.api.Test;
3131

32+
import lombok.extern.slf4j.Slf4j;
33+
3234
import java.io.File;
3335
import java.net.URL;
3436
import java.nio.file.Paths;
@@ -39,6 +41,7 @@
3941

4042
import static org.apache.hadoop.fs.CommonConfigurationKeysPublic.FS_DEFAULT_NAME_DEFAULT;
4143

44+
@Slf4j
4245
public class ParquetReadStrategyTest {
4346
@Test
4447
public void testParquetRead1() throws Exception {
@@ -51,7 +54,7 @@ public void testParquetRead1() throws Exception {
5154
SeaTunnelRowType seaTunnelRowTypeInfo =
5255
parquetReadStrategy.getSeaTunnelRowTypeInfo(localConf, path);
5356
Assertions.assertNotNull(seaTunnelRowTypeInfo);
54-
System.out.println(seaTunnelRowTypeInfo);
57+
log.info(seaTunnelRowTypeInfo.toString());
5558
TestCollector testCollector = new TestCollector();
5659
parquetReadStrategy.read(path, "", testCollector);
5760
}
@@ -67,7 +70,7 @@ public void testParquetRead2() throws Exception {
6770
SeaTunnelRowType seaTunnelRowTypeInfo =
6871
parquetReadStrategy.getSeaTunnelRowTypeInfo(localConf, path);
6972
Assertions.assertNotNull(seaTunnelRowTypeInfo);
70-
System.out.println(seaTunnelRowTypeInfo);
73+
log.info(seaTunnelRowTypeInfo.toString());
7174
TestCollector testCollector = new TestCollector();
7275
parquetReadStrategy.read(path, "", testCollector);
7376
}
@@ -83,7 +86,7 @@ public void testParquetReadUseSystemDefaultTimeZone() throws Exception {
8386
SeaTunnelRowType seaTunnelRowTypeInfo =
8487
parquetReadStrategy.getSeaTunnelRowTypeInfo(localConf, path);
8588
Assertions.assertNotNull(seaTunnelRowTypeInfo);
86-
System.out.println(seaTunnelRowTypeInfo);
89+
log.info(seaTunnelRowTypeInfo.toString());
8790
int index = seaTunnelRowTypeInfo.indexOf("c_timestamp");
8891
TimeZone tz1 = TimeZone.getTimeZone("Asia/Shanghai");
8992
TimeZone.setDefault(tz1);
@@ -119,7 +122,7 @@ public void testParquetReadProjection1() throws Exception {
119122
SeaTunnelRowType seaTunnelRowTypeInfo =
120123
parquetReadStrategy.getSeaTunnelRowTypeInfo(localConf, path);
121124
Assertions.assertNotNull(seaTunnelRowTypeInfo);
122-
System.out.println(seaTunnelRowTypeInfo);
125+
log.info(seaTunnelRowTypeInfo.toString());
123126
TestCollector testCollector = new TestCollector();
124127
parquetReadStrategy.read(path, "", testCollector);
125128
List<SeaTunnelRow> rows = testCollector.getRows();
@@ -149,7 +152,7 @@ public void testParquetReadProjection2() throws Exception {
149152
SeaTunnelRowType seaTunnelRowTypeInfo =
150153
parquetReadStrategy.getSeaTunnelRowTypeInfo(localConf, path);
151154
Assertions.assertNotNull(seaTunnelRowTypeInfo);
152-
System.out.println(seaTunnelRowTypeInfo);
155+
log.info(seaTunnelRowTypeInfo.toString());
153156
TestCollector testCollector = new TestCollector();
154157
parquetReadStrategy.read(path, "", testCollector);
155158
}
@@ -164,7 +167,7 @@ public List<SeaTunnelRow> getRows() {
164167

165168
@Override
166169
public void collect(SeaTunnelRow record) {
167-
System.out.println(record);
170+
log.info(record.toString());
168171
rows.add(record);
169172
}
170173

‎seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/psql/PostgresCatalogTest.java‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@
2525
import org.junit.jupiter.api.Disabled;
2626
import org.junit.jupiter.api.Test;
2727

28+
import lombok.extern.slf4j.Slf4j;
29+
2830
@Disabled("Please Test it in your local environment")
31+
@Slf4j
2932
class PostgresCatalogTest {
3033

3134
@Test
@@ -51,7 +54,7 @@ void testCatalog() {
5154

5255
CatalogTable table =
5356
catalog.getTable(TablePath.of("st_test", "public", "all_types_table_02"));
54-
System.out.println("find table: " + table);
57+
log.info("find table: " + table);
5558

5659
catalog.createTable(
5760
new TablePath("liulitest", "public", "all_types_table_02"), table, false);

‎seatunnel-connectors-v2/connector-starrocks/src/test/java/org/apache/seatunnel/connectors/seatunnel/starrocks/catalog/StarRocksCreateTableTest.java‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,13 @@
2929
import org.junit.jupiter.api.Assertions;
3030
import org.junit.jupiter.api.Test;
3131

32+
import lombok.extern.slf4j.Slf4j;
33+
3234
import java.util.ArrayList;
3335
import java.util.Arrays;
3436
import java.util.List;
3537

38+
@Slf4j
3639
public class StarRocksCreateTableTest {
3740

3841
@Test
@@ -71,7 +74,7 @@ public void test() {
7174
.columns(columns)
7275
.build());
7376

74-
System.out.println(result);
77+
log.info(result);
7578
}
7679

7780
@Test

‎seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterFaultToleranceIT.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ public void testBatchJobRunOkIn2Node() throws ExecutionException, InterruptedExc
134134
Long fileLineNumberFromDir =
135135
FileUtils.getFileLineNumberFromDir(testResources.getLeft());
136136
Assertions.assertEquals(testRowNumber * testParallelism, fileLineNumberFromDir);
137-
System.out.println(engineClient.getJobMetrics(clientJobProxy.getJobId()));
137+
log.info(engineClient.getJobMetrics(clientJobProxy.getJobId()));
138138
log.warn("========================clean test resource====================");
139139
} finally {
140140
if (engineClient != null) {

‎seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterIT.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,12 @@ public void getClusterHealthMetrics() {
6565
engineClient = new SeaTunnelClient(clientConfig);
6666

6767
Map<String, String> clusterHealthMetrics = engineClient.getClusterHealthMetrics();
68-
System.out.println(
68+
log.info(
6969
"=====================================cluster metrics==================================================");
7070
for (Map.Entry<String, String> entry : clusterHealthMetrics.entrySet()) {
71-
System.out.println(entry.getKey());
72-
System.out.println(entry.getValue());
73-
System.out.println(
71+
log.info(entry.getKey());
72+
log.info(entry.getValue());
73+
log.info(
7474
"======================================================================================================");
7575
}
7676
Assertions.assertEquals(2, clusterHealthMetrics.size());

‎seatunnel-engine/seatunnel-engine-client/src/test/java/org/apache/seatunnel/engine/client/SeaTunnelClientTest.java‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
import com.hazelcast.client.config.ClientConfig;
4646
import com.hazelcast.core.HazelcastInstance;
4747
import com.hazelcast.instance.impl.HazelcastInstanceFactory;
48+
import lombok.extern.slf4j.Slf4j;
4849

4950
import java.util.concurrent.CompletableFuture;
5051
import java.util.concurrent.ExecutionException;
@@ -57,6 +58,7 @@
5758
import static org.awaitility.Awaitility.await;
5859

5960
@DisabledOnOs(OS.WINDOWS)
61+
@Slf4j
6062
public class SeaTunnelClientTest {
6163

6264
private static SeaTunnelConfig SEATUNNEL_CONFIG = ConfigProvider.locateAndGetSeaTunnelConfig();
@@ -201,7 +203,7 @@ public void testGetJobMetrics() {
201203

202204
String jobMetrics = jobClient.getJobMetrics(jobId);
203205

204-
System.out.println(jobMetrics);
206+
log.info(jobMetrics);
205207

206208
Assertions.assertTrue(jobMetrics.contains(SOURCE_RECEIVED_COUNT));
207209
Assertions.assertTrue(jobMetrics.contains(SOURCE_RECEIVED_QPS));
@@ -258,7 +260,7 @@ public void testGetRunningJobMetrics() throws ExecutionException, InterruptedExc
258260
.getJobStatus(jobId3)
259261
.equals("RUNNING")));
260262

261-
System.out.println(jobClient.getRunningJobMetrics());
263+
log.info(jobClient.getRunningJobMetrics());
262264

263265
await().atMost(30000, TimeUnit.MILLISECONDS)
264266
.untilAsserted(
@@ -334,10 +336,10 @@ public void testGetJobInfo() {
334336
.untilAsserted(
335337
() -> {
336338
Thread.sleep(1000);
337-
System.out.println(
339+
log.info(
338340
"======================job status:"
339341
+ jobClient.getJobDetailStatus(jobId));
340-
System.out.println(
342+
log.info(
341343
"======================list job status:"
342344
+ jobClient.listJobStatus(true));
343345
Assertions.assertTrue(

‎seatunnel-engine/seatunnel-engine-client/src/test/java/org/apache/seatunnel/engine/client/TestUtils.java‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,12 @@
2323

2424
import org.junit.jupiter.api.Test;
2525

26+
import lombok.extern.slf4j.Slf4j;
27+
2628
import java.util.ArrayList;
2729
import java.util.List;
2830

31+
@Slf4j
2932
public class TestUtils {
3033
public static String getResource(String confFile) {
3134
return System.getProperty("user.dir") + "/src/test/resources/" + confFile;
@@ -67,6 +70,6 @@ public void testContentFormatUtil() throws InterruptedException {
6770
return s1.getSubmitTime() > s2.getSubmitTime() ? -1 : 1;
6871
});
6972
String r = ContentFormatUtil.format(statusDataList);
70-
System.out.println(r);
73+
log.info(r);
7174
}
7275
}

‎seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointSerializeTest.java‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,14 @@
2828
import org.junit.jupiter.api.Disabled;
2929
import org.junit.jupiter.api.Test;
3030

31+
import lombok.extern.slf4j.Slf4j;
32+
3133
import java.io.File;
3234
import java.io.FileInputStream;
3335
import java.io.IOException;
3436
import java.util.List;
3537

38+
@Slf4j
3639
public class CheckpointSerializeTest {
3740

3841
@Test
@@ -66,7 +69,7 @@ public void testPipelineStateDeserialize() throws IOException {
6669
DefaultSerializer<FakeSourceSplit> defaultSerializer =
6770
new DefaultSerializer<FakeSourceSplit>();
6871
FakeSourceSplit split = defaultSerializer.deserialize(bytes);
69-
System.out.println(split.getSplitId());
72+
log.info(String.valueOf(split.getSplitId()));
7073
}
7174
}
7275

@@ -84,7 +87,7 @@ public void testPipelineStateDeserialize() throws IOException {
8487
DefaultSerializer<FileSinkState> defaultSerializer =
8588
new DefaultSerializer<FileSinkState>();
8689
FileSinkState fileSinkState = defaultSerializer.deserialize(bytes);
87-
System.out.println(fileSinkState.getTransactionDir());
90+
log.info(fileSinkState.getTransactionDir());
8891
}
8992
}
9093
}

‎seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/master/JobMetricsTest.java‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import org.junit.jupiter.api.condition.OS;
3434

3535
import com.hazelcast.internal.serialization.Data;
36+
import lombok.extern.slf4j.Slf4j;
3637

3738
import java.util.Collections;
3839
import java.util.concurrent.TimeUnit;
@@ -48,6 +49,7 @@
4849

4950
@DisabledOnOs(OS.WINDOWS)
5051
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
52+
@Slf4j
5153
class JobMetricsTest extends AbstractSeaTunnelServerTest {
5254

5355
@Test
@@ -112,7 +114,7 @@ public void testMetricsOnJobRestart() throws InterruptedException {
112114

113115
Thread.sleep(10000);
114116

115-
System.out.println(coordinatorService.getJobMetrics(jobId3).toJsonString());
117+
log.info(coordinatorService.getJobMetrics(jobId3).toJsonString());
116118

117119
// start savePoint
118120
coordinatorService.savePoint(jobId3);
@@ -137,7 +139,7 @@ public void testMetricsOnJobRestart() throws InterruptedException {
137139
Thread.sleep(20000);
138140
// check metrics
139141
JobMetrics jobMetrics = coordinatorService.getJobMetrics(jobId3);
140-
System.out.println(jobMetrics.toJsonString());
142+
log.info(jobMetrics.toJsonString());
141143
assertTrue(40 < (Long) jobMetrics.get(SINK_WRITE_COUNT).get(0).value());
142144
assertTrue(40 < (Long) jobMetrics.get(SINK_WRITE_COUNT).get(1).value());
143145
assertTrue(40 < (Long) jobMetrics.get(SOURCE_RECEIVED_COUNT).get(0).value());

0 commit comments

Comments
 (0)